Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] API-847 - Making the enum migration more smooth. #850

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

xlorepdarkhelm
Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm commented Mar 12, 2024

This is an effort to correct an issue found in staging. It removes all records in the service_permissions table in the database that have invalid permission types assigned to them, right before switching to using the enum type. This should get us past the current blocking problem we're seeing in staging.

Reference: #847

Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
@xlorepdarkhelm xlorepdarkhelm requested a review from a team March 12, 2024 19:23
@xlorepdarkhelm xlorepdarkhelm self-assigned this Mar 12, 2024
Copy link
Contributor

@terrazoon terrazoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume we don't need to handle rollback since these are non-sms permission we aren't using.

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @xlorepdarkhelm! We should not need these anymore.

@ccostino ccostino merged commit 6713585 into main Mar 12, 2024
5 checks passed
@ccostino ccostino deleted the API-847_Clobbering_bad_enum_data branch March 12, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants