Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message send flow docs #863

Merged
merged 7 commits into from
Mar 28, 2024
Merged

Message send flow docs #863

merged 7 commits into from
Mar 28, 2024

Conversation

A-Shumway42
Copy link
Member

Description

This PR adds docs in all.md explaining the general path of the message send flow. Code comments have been added in the logic to help explain the process.

Security Considerations

None

xlorepdarkhelm
xlorepdarkhelm requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some PEP-257 requested changes.

app/celery/provider_tasks.py Outdated Show resolved Hide resolved
app/celery/tasks.py Outdated Show resolved Hide resolved
app/celery/tasks.py Outdated Show resolved Hide resolved
app/celery/tasks.py Outdated Show resolved Hide resolved
app/delivery/send_to_providers.py Show resolved Hide resolved
app/job/rest.py Outdated Show resolved Hide resolved
xlorepdarkhelm
xlorepdarkhelm approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting the PEP-257 updates in., Just one very minor detail (a space before the first word in a comment), otherwise, LGTM. Will approve (please get the little fix, of course).

app/celery/tasks.py Outdated Show resolved Hide resolved
@A-Shumway42 A-Shumway42 linked an issue Mar 28, 2024 that may be closed by this pull request
Document the message-sending code path #820
Closed
3 tasks
ccostino
ccostino approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @A-Shumway42!

@ccostino ccostino merged commit 6396dbe into main Mar 28, 2024
5 checks passed
@ccostino ccostino deleted the message-send-flow-docs branch March 28, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlorepdarkhelm xlorepdarkhelm xlorepdarkhelm approved these changes

@ccostino ccostino ccostino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document the message-sending code path
3 participants
@A-Shumway42 @ccostino @xlorepdarkhelm