-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
login.gov first time workflow notify-api-1250 #865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just have questions about passwords/login. Will dev work flow through the login.gov sign in? If not, would we still need the password column for devs?
Dev flow is going to have to change. We will have to run the "create test user" command in order to create the first user in a clean setup. After that, we will have to log in with login.gov whether we use the sign in page, or respond to an invite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @terrazoon!
Description
The new "Set Up Your Profile" workflow for first time users involves them being redirected to the login.gov website after they click "Join Service" in the invitation email.
TODO (optional)
Security Considerations
N/A