Added ability for poetry to add and delete the test_notifications_api db during tests for #598 #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create and delete the test_notifications_api db before and after the tests run.
anagradova
added
engineering
dependencies
4 tasks
ccostino
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Oh awesome, thanks @anagradova! This should also help get things back on track for running tests in parallel for the API, right @stvnrlly?
I have just one small thing to try out for keeping our dependencies organized, but otherwise this should be good!
xlorepdarkhelm
requested changes
Apr 11, 2024
ccostino
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Thank you, @anagradova!
@xlorepdarkhelm, you'll have to approve too now that the change is made. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Installed the python library sqlalchemy-utils which contains the methods database_exists, create_database, drop_database. I modified the _notify_db method in conftest.py to allow for the method to check if the test_notifications_api db exists, if it does it will create it. After all tests run and during deconstruction, the _notify_db method will then remove the test_notifications_api database as part of it's cleanup.
This should include:
Re-introduce database creation for tests #598
NA
Added sqlalchemy-utils to poetry lock
Security Considerations
NA