Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated notification #916

Merged
merged 1 commit into from
Apr 11, 2024
Merged

remove deprecated notification #916

merged 1 commit into from
Apr 11, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Apr 11, 2024

Description

The write-up for this ticket was done at the time when we still had phone numbers in the db, and were trying to be alerted when the number of phone numbers in the db approached 10,000.

(Recipient) phone number have been removed from the database, so there is no longer a need for this notification. It's been removed, along with the scheduled, and some tests were fixed that were mocking the wrong redis call (but still passing somehow).

Security Considerations

N/A

@terrazoon terrazoon self-assigned this Apr 11, 2024
@terrazoon terrazoon linked an issue Apr 11, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

@ccostino ccostino merged commit f6c1c80 into main Apr 11, 2024
5 checks passed
@ccostino ccostino deleted the notify-api-662 branch April 11, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert email reference to an environment variable reference
3 participants