Feat/accept student #103

KimTaeO · 2023-03-06T13:19:09Z

💡 개요

학생 회원가입 수락 api 작성

📃 작업내용

🔀 변경사항

🙋‍♂️ 질문사항

⚗️ 사용법

🎸 기타

esperar · 2023-03-07T01:20:22Z

src/main/kotlin/com/msg/gauth/domain/user/services/AcceptStudentSignUpService.kt

+        val user = userRepository.findByIdAndStateAndRoles(acceptedStudentReqDto.id, UserState.PENDING, mutableListOf(UserRole.ROLE_STUDENT))
+            ?: throw UserNotFoundException()
+
+        user.update(acceptedStudentReqDto.name, acceptedStudentReqDto.grade, acceptedStudentReqDto.classNum, acceptedStudentReqDto.num,acceptedStudentReqDto.gender)


save해야하는거 아닌가?

더티체킹되기는하는데, 아무래도 save하는게 든든하지 @KimTaeO

save 하게 변경했습니다
67d33ca

src/main/kotlin/com/msg/gauth/domain/user/presentation/UserController.kt

yoonjibin · 2023-03-10T01:57:49Z

src/main/kotlin/com/msg/gauth/domain/user/services/AcceptStudentSignUpService.kt

+        val user = userRepository.findByIdAndStateAndRoles(acceptedStudentReqDto.id, UserState.PENDING, mutableListOf(UserRole.ROLE_STUDENT))
+            ?: throw UserNotFoundException()
+
+        userRepository.save(user.update(acceptedStudentReqDto.name, acceptedStudentReqDto.grade, acceptedStudentReqDto.classNum, acceptedStudentReqDto.num,acceptedStudentReqDto.gender))


이 부분 좀 깔끔하게 바꿔주세요..

넵 바꿨습니다
5cca886

siwony

프로젝트 재미있어 보여서 구경왔습니다

siwony · 2023-03-15T15:51:32Z

src/main/kotlin/com/msg/gauth/domain/user/presentation/dto/request/AcceptStudentReqDto.kt

+    @field: NotBlank
+    val id: Long,
+    @field: NotBlank
+    val name: String,
+    @field: NotBlank
+    val gender: Gender,
+    @field: NotBlank
+    val grade: Int,
+    @field: NotBlank
+    val classNum: Int,
+    @field: NotBlank
+    val num: Int


@NotBlank는 String type에서만 동작합니다.

공식문서: https://javaee.github.io/javaee-spec/javadocs/javax/validation/constraints/NotBlank.html

추가로 non-nullable타입에서 null이 request로 받는다면 MethodArgumentNotValidException가 아닌 다른 exception이 발생합니다 (오래되서 기억이 잘 안나네요)

작년에 hirecruit라는 프로젝트를 했었는데 저도 kotlin에서 꾸역꾸역 bean validator 썻던 기억이 있네요 참고하세요~

https://github.com/themoment-team/HiRecruit-server/blob/master/src/main/java/site/hirecruit/hr/domain/company/dto/CompanyDto.kt

일단 구경오시고, 리뷰도 달아주셨는데 추한 모습 보여드리고 리뷰 코멘트도 늦게 단 점 부끄럽네요 그래도 이번 기회로 검증 어노테이션 소홀이 작성 할 일 없을 것 같습니다..ㅋㅋ 재밌는 구경이었길 바라겠습니닷!
e553188

src/main/kotlin/com/msg/gauth/domain/user/presentation/dto/request/AcceptStudentReqDto.kt

KimTaeO added 4 commits March 6, 2023 18:23

✨ 학생 회원가입 수락 request Dto 작성

9c73c45

✨ 학생 수락 requestDto 작성

6929f85

✨ 학생 수락 서비스 작성

0a9a5cb

✨ 학생 회원가입 수락 컨트롤러 작성

b739e16

KimTaeO requested review from baekteun, dolong2 and esperar March 6, 2023 13:19

KimTaeO linked an issue Mar 6, 2023 that may be closed by this pull request

학생 회원가입 수락 api #102

Closed

✨ securityConfig 경로 설정

1e10f37

esperar reviewed Mar 7, 2023

View reviewed changes

✨ save 사용

67d33ca

baekteun approved these changes Mar 10, 2023

View reviewed changes

dolong2 reviewed Mar 10, 2023

View reviewed changes

src/main/kotlin/com/msg/gauth/domain/user/presentation/UserController.kt Show resolved Hide resolved

yoonjibin reviewed Mar 10, 2023

View reviewed changes

✨ dto에 검증로직 추가

f960b91

dolong2 approved these changes Mar 14, 2023

View reviewed changes

✨ update 함수에서 접근자로 데이터 가져오도록 변경

5cca886

siwony reviewed Mar 15, 2023

View reviewed changes

KimTaeO added 2 commits March 16, 2023 21:04

✨ 검증 어노테이션 String이 아닌 것들 NotNull로 변경 또는 삭제

e553188

✨ main branch pull 받으며 생긴 컨플릭트 해결

d63135c

baekteun reviewed Mar 16, 2023

View reviewed changes

src/main/kotlin/com/msg/gauth/domain/user/presentation/dto/request/AcceptStudentReqDto.kt Show resolved Hide resolved

KimTaeO merged commit 967aaf3 into main Mar 18, 2023

KimTaeO deleted the feat/accept-student branch March 18, 2023 13:28

KimTaeO added 0️⃣Priority: Critical 우선순위 긴급 ✨ Feature 기능 개발 labels Aug 23, 2023

KimTaeO self-assigned this Jan 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/accept student #103

Feat/accept student #103

KimTaeO commented Mar 6, 2023 •

edited

Loading

esperar Mar 7, 2023

baekteun Mar 7, 2023

KimTaeO Mar 7, 2023

yoonjibin Mar 10, 2023

KimTaeO Mar 16, 2023

siwony left a comment

siwony Mar 15, 2023

siwony Mar 15, 2023

KimTaeO Mar 16, 2023

Feat/accept student #103

Feat/accept student #103

Conversation

KimTaeO commented Mar 6, 2023 • edited Loading

💡 개요

📃 작업내용

🔀 변경사항

🙋‍♂️ 질문사항

⚗️ 사용법

🎸 기타

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

siwony left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KimTaeO commented Mar 6, 2023 •

edited

Loading