Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

회원가입 수락 유저 리스트 api #116

Merged
merged 10 commits into from
Mar 27, 2023

Conversation

KimTaeO
Copy link
Contributor

@KimTaeO KimTaeO commented Mar 22, 2023

💡 개요

회원가입이 수락된 유저들을 가져오는 api가 작동하지 않아서 코드를 갈아엎었습니다

📃 작업내용

🔀 변경사항

🙋‍♂️ 질문사항

⚗️ 사용법

🎸 기타

@KimTaeO KimTaeO linked an issue Mar 22, 2023 that may be closed by this pull request
Comment on lines 32 to 38
grade == 0 && classNum == 0 -> findAllByStateAndNameContaining(state, name)
classNum == 0 && name == "0" -> findAllByStateAndClassNum(state, classNum)
grade == 0 && name == "0"-> findAllByStateAndGrade(state, grade)
grade == 0 -> findAllByStateAndClassNumAndNameContaining(state, classNum, name)
classNum == 0 -> findAllByStateAndGradeAndNameContaining(state, grade, name)
name == "0" -> findAllByStateAndGradeAndClassNum(state, grade, classNum)
else -> findAllByStateAndGradeAndClassNumAndNameContaining(state, grade, classNum, name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name은 0으로 안오는데

Copy link
Member

@baekteun baekteun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm

@KimTaeO KimTaeO merged commit 8d61bc2 into main Mar 27, 2023
@KimTaeO KimTaeO deleted the 115-accepted-user-list-api-not-funtion branch March 27, 2023 03:22
@KimTaeO KimTaeO added 🔨 Refactor 코드 리팩토링 1️⃣Priority: High 우선순위 상 labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣Priority: High 우선순위 상 🔨 Refactor 코드 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

수락된 유저 list api가 작동하지 않는 이슈
4 participants