-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
회원가입 수락 유저 리스트 api #116
Merged
Merged
회원가입 수락 유저 리스트 api #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esperar
reviewed
Mar 22, 2023
src/main/kotlin/com/msg/gauth/domain/user/services/AcceptedUserService.kt
Outdated
Show resolved
Hide resolved
esperar
reviewed
Mar 22, 2023
src/main/kotlin/com/msg/gauth/domain/user/services/AcceptedUserService.kt
Outdated
Show resolved
Hide resolved
dolong2
approved these changes
Mar 22, 2023
esperar
approved these changes
Mar 23, 2023
baekteun
reviewed
Mar 23, 2023
Comment on lines
32
to
38
grade == 0 && classNum == 0 -> findAllByStateAndNameContaining(state, name) | ||
classNum == 0 && name == "0" -> findAllByStateAndClassNum(state, classNum) | ||
grade == 0 && name == "0"-> findAllByStateAndGrade(state, grade) | ||
grade == 0 -> findAllByStateAndClassNumAndNameContaining(state, classNum, name) | ||
classNum == 0 -> findAllByStateAndGradeAndNameContaining(state, grade, name) | ||
name == "0" -> findAllByStateAndGradeAndClassNum(state, grade, classNum) | ||
else -> findAllByStateAndGradeAndClassNumAndNameContaining(state, grade, classNum, name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name은 0으로 안오는데
baekteun
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
회원가입이 수락된 유저들을 가져오는 api가 작동하지 않아서 코드를 갈아엎었습니다
📃 작업내용
🔀 변경사항
🙋♂️ 질문사항
⚗️ 사용법
🎸 기타