Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

129 서비스명이 다 불편하네요 갈아엎어주세요 #130

Merged

Conversation

esperar
Copy link
Contributor

@esperar esperar commented Apr 5, 2023

💡 개요

📃 작업내용

🔀 변경사항

🙋‍♂️ 질문사항

⚗️ 사용법

🎸 기타

@esperar esperar linked an issue Apr 5, 2023 that may be closed by this pull request
@dolong2
Copy link
Member

dolong2 commented Apr 5, 2023

MyProfileService -> GetMyProfileService로 바꾸는것도 좋을거 같아요

@esperar
Copy link
Contributor Author

esperar commented Apr 5, 2023

Get 추가했습니당

@dolong2
Copy link
Member

dolong2 commented Apr 5, 2023

email services 부분을
MailSendService -> SendMailService
MailVerificationCheckService -> CheckMailVerificationService
MailVerficationService -> VerifyMailService
이런식으로 바꿔야 네이밍이 통일될거 같아요

@esperar esperar merged commit 12bb380 into main Apr 5, 2023
@esperar esperar deleted the 129-서비스명이-다-불편하네요-갈아엎어주세요 branch April 5, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

서비스명이 다 불편하네요. 갈아엎어"주세요"
4 participants