Client로직 추가 #20
Merged
Client로직 추가 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baekteun
reviewed
Sep 21, 2022
Comment on lines
6
to
7
| class ClientNotFindException: BasicException(ErrorCode.CLIENT_NOT_FOUND) { | ||
| } |
| } | ||
|
|
||
| @GetMapping | ||
| fun getAllClients(): ResponseEntity<List<ClientAllResDto>>{ |
There was a problem hiding this comment.
Suggested change
| fun getAllClients(): ResponseEntity<List<ClientAllResDto>>{ | |
| fun getMyAllClients(): ResponseEntity<List<ClientAllResDto>>{ |
어떰
| private val currentUserUtil: CurrentUserUtil, | ||
| ){ | ||
| fun execute(clientRegisterDto: ClientRegisterReqDto): ClientRegisterResDto { | ||
| val clientSecret = UUID.randomUUID().toString().replace("-", "") + UUID.randomUUID().toString().replace("-", "") |
There was a problem hiding this comment.
Suggested change
| val clientSecret = UUID.randomUUID().toString().replace("-", "") + UUID.randomUUID().toString().replace("-", "") | |
| val clientSecret = (UUID.randomUUID().toString()+ UUID.randomUUID().toString()).replace("-", "") |
이런식 어떰
| class GetOneClientService( | ||
| private val clientRepository: ClientRepository, | ||
| private val currentUserUtil: CurrentUserUtil, | ||
| ){ |
There was a problem hiding this comment.
Transactional(readOnly = true) 어떰
baekteun
reviewed
Sep 21, 2022
| @PatchMapping("/{id}") | ||
| fun updateClient(@PathVariable id:String, @RequestBody clientUpdateDto: ClientUpdateReqDto): ResponseEntity<Void>{ | ||
| updateClientService.updateClient(id, clientUpdateDto) | ||
| return ResponseEntity.ok().build() |
| val serviceName: String, | ||
| val serviceUri: String, | ||
| ) { | ||
| constructor(client:Client): this( |
There was a problem hiding this comment.
Suggested change
| constructor(client:Client): this( | |
| constructor(client: Client): this( |
으악 린트 불편해용
| } | ||
|
|
||
| fun getCurrentUser(): User = | ||
| userRepository.findByEmail(getCurrentEmail())!! |
baekteun
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
한일