Feature/oauth logic #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baekteun
reviewed
Oct 12, 2022
| @@ -7,4 +7,6 @@ import org.springframework.data.jpa.repository.JpaRepository | |||
| interface ClientRepository: JpaRepository<Client, Long> { | |||
| fun findAllByCreatedBy(createdBy: User): List<Client> | |||
| fun findByIdAndCreatedBy(clientId: Long, createdBy: User): Client? | |||
|
|
|||
src/main/kotlin/com/msg/gauth/domain/oauth/exception/ClientSecretMismatchException.kt
Outdated
Show resolved
Hide resolved
| val oauthUserInfoService: OauthUserInfoService, | ||
| ){ | ||
| @PostMapping("/login") | ||
| fun oauthLogin(@Validated @RequestBody oauthLoginRequestDto : OauthLoginRequestDto): ResponseEntity<OauthLoginResponseDto> = |
| @@ -0,0 +1,7 @@ | |||
| package com.msg.gauth.domain.oauth.presentation.dto.request | |||
|
|
|||
| class UserInfoRequestDto( | |||
| @@ -0,0 +1,5 @@ | |||
| package com.msg.gauth.domain.oauth.presentation.dto.response | |||
|
|
|||
| class OauthLoginResponseDto( | |||
|
|
||
| import com.msg.gauth.domain.user.enums.Gender | ||
|
|
||
| class UserInfoResponseDto( |
src/main/kotlin/com/msg/gauth/domain/oauth/presentation/dto/response/UserInfoResponseDto.kt
Show resolved
Hide resolved
Comment on lines
23
to
37
| fun execute(userInfoRequestDto: UserInfoRequestDto): UserInfoResponseDto{ | ||
| val valueOperation = redisTemplate.opsForValue() | ||
| val client = clientRepository.findByClientId(userInfoRequestDto.clientId) ?: throw ClientNotFindException() | ||
| if(client.clientSecret != userInfoRequestDto.clientSecret) | ||
| throw ClientSecretMismatchException() | ||
| val email = valueOperation.get(userInfoRequestDto.code) ?: throw OauthCodeExpiredException() | ||
| val user = userRepository.findByEmail(email) ?: throw UserNotFoundException() | ||
| return UserInfoResponseDto( | ||
| email = user.email, | ||
| grade = user.grade, | ||
| classNum = user.classNum, | ||
| num = user.num, | ||
| gender = user.gender | ||
| ) | ||
| } |
There was a problem hiding this comment.
유저 State PENDING이면 Exception띄우는거 어때
…retMismatchException.kt Co-authored-by: baegteun <74440939+baekteun@users.noreply.github.com>
baekteun
reviewed
Oct 12, 2022
src/main/kotlin/com/msg/gauth/domain/client/repository/ClientRepository.kt
Outdated
Show resolved
Hide resolved
…epository.kt Co-authored-by: baegteun <74440939+baekteun@users.noreply.github.com>
baekteun
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
한일
플로우 제대로 이해했는지 몰루