Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#397) - ๋””๋ฐ”์ด์Šค ํฌ๊ธฐ์— ๋งž๊ฒŒ ๋ฒ„ํŠผํฌ๊ธฐ ๋งž์ถฐ์ง€๋„๋ก ์ฝ”๋“œ ๋ณ€๊ฒฝ #398

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

khs3994
Copy link
Collaborator

@khs3994 khs3994 commented Mar 13, 2023

PR ์ •๋ณด

  • ๋””๋ฐ”์ด์Šค ํฌ๊ธฐ์— ๋ฒ„ํŠผํฌ๊ธฐ๊ฐ€ ๋งž์ถฐ์ง€๋„๋ก ๋ณ€๊ฒฝํ•จ

์ฃผ์š”์ฝ”๋“œ

  • ๋””๋ฐ”์ด์Šค ์‚ฌ์ด์ฆˆ ๊ตฌํ•ด์„œ ๋ฒ„ํŠผ์— ํฌ๊ธฐ ์ ์šฉ
    private fun setGAuthButtonComponent() {
    val display: Display = windowManager.defaultDisplay
    val outMetrics = DisplayMetrics()
    display.getMetrics(outMetrics)
    val density = resources.displayMetrics.density
    val dpWidth = outMetrics.widthPixels / density
    binding.signInBtn.setContent {
    GAuthButton(
    style = Types.Style.DEFAULT,
    actionType = Types.ActionType.SIGNIN,
    colors = Types.Colors.OUTLINE,
    horizontalPaddingValue = (dpWidth / 2 - 120).dp
    ) {
    binding.gAuthWebView.visibility = View.VISIBLE
    setGAuthWebViewComponent()
    }
    }
    }

@khs3994 khs3994 added the CORRECTIONS ์ž์ž˜ํ•œ ์ˆ˜์ •๋“ค์„ ๋‚˜ํƒ€๋ƒ…๋‹ˆ๋‹ค. label Mar 13, 2023
@khs3994 khs3994 self-assigned this Mar 13, 2023
@khs3994 khs3994 merged commit ee5c35b into develop Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORRECTIONS ์ž์ž˜ํ•œ ์ˆ˜์ •๋“ค์„ ๋‚˜ํƒ€๋ƒ…๋‹ˆ๋‹ค.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋กœ๊ทธ์ธ ๋ฒ„ํŠผ ์ฐŒ๊ทธ๋Ÿฌ์ง ํ˜„์ƒ ํ•ด๊ฒฐ
3 participants