Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔀 :: (#417) - modify the methods of transfer data between data layer and domain layer #418

Conversation

leehyeonbin
Copy link
Contributor

PR 정보

기존의 계층 간 데이터를 변환해주던 Mapper가 Extension으로 변경되었습니다.

  • 매퍼를 사용하기 위해 클래스를 임포트하고 사용하던 일련의 과정이 불편하고 가독성이 떨어짐

작업 결과

모든 mapper가 아래와 같이 변경되었습니다.

fun ClubMemberResponse.toClubMemberData(): ClubMemberData {
return ClubMemberData(
uuid = uuid,
email = email,
`class` = `class`,
grade = grade,
name = name,
num = num,
userImg = userImg
)
}

@leehyeonbin leehyeonbin added the REFAC 리팩토링이 필요함을 나타냅니다. label Apr 15, 2023
@leehyeonbin leehyeonbin self-assigned this Apr 15, 2023
@leehyeonbin leehyeonbin linked an issue Apr 15, 2023 that may be closed by this pull request
Copy link
Collaborator

@khs3994 khs3994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leehyeonbin leehyeonbin merged commit b04c393 into develop Apr 15, 2023
@leehyeonbin leehyeonbin deleted the feature/417_modify_the_methods_of_transfor_data_between_data_layer_and_domain_layer branch April 15, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REFAC 리팩토링이 필요함을 나타냅니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapper is so low readability
3 participants