generated from GSM-MSG/MSG-Repository-Generator
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
공지사항 작성 api를 개발했습니다 #300
Merged
Merged
공지사항 작성 api를 개발했습니다 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ani2689
requested review from
louis7308,
Huuuunee,
dolong2,
yoonjibin,
KimTaeO and
JuuuuHong
as code owners
March 27, 2024 23:19
Closed
KimTaeO
reviewed
Mar 28, 2024
?: throw ClubNotFoundException() | ||
|
||
when(user.roles) { | ||
listOf(Role.ROLE_ADMIN) -> {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 줄은 없애도 되지 않을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d58b9e0 짧게 리팩토링 했어요!
KimTaeO
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
공지사항 작성 api를 개발했습니다.
📃 작업내용
title과 content를 받아 공지사항을 개설합니다.
선생님과 동아리 부장이 아니면 예외가 발생합니다.
🔀 변경사항
🙋♂️ 질문사항
🍴 사용방법
🎸 기타
pr을 머지한 후 앱 푸시알람 기능을 추가하겠습니다.