Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: custom repository condition #346

Merged
merged 1 commit into from
Apr 25, 2024
Merged

πŸ”€ :: custom repository condition #346

merged 1 commit into from
Apr 25, 2024

Conversation

KimTaeO
Copy link
Contributor

@KimTaeO KimTaeO commented Apr 25, 2024 •
edited
Loading

πŸ’‘ λ°°κ²½ 및 κ°œμš”

이전 pr의 κ΅¬ν˜„μ²΄ 변경을 κΉœλΉ‘ν–ˆμŠ΅λ‹ˆλ‹€

Resolves: #345

πŸ“ƒ μž‘μ—…λ‚΄μš©

μ»€μŠ€ν…€ 리포지토리 κ΅¬ν˜„μ²΄ μˆ˜μ •

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. .env, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "ν™˜κ²½κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@KimTaeO KimTaeO added the 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!! label Apr 25, 2024
@KimTaeO KimTaeO self-assigned this Apr 25, 2024
@KimTaeO KimTaeO linked an issue Apr 25, 2024 that may be closed by this pull request
existByDateAndPeriodsAndClub κ΅¬ν˜„ #345
Closed
@KimTaeO KimTaeO merged commit 89e8da3 into develop Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ani2689 ani2689 ani2689 approved these changes

@louis7308 louis7308 Awaiting requested review from louis7308 louis7308 is a code owner

@Huuuunee Huuuunee Awaiting requested review from Huuuunee Huuuunee is a code owner

@dolong2 dolong2 Awaiting requested review from dolong2 dolong2 is a code owner

@yoonjibin yoonjibin Awaiting requested review from yoonjibin yoonjibin is a code owner

@ta2ye0n ta2ye0n Awaiting requested review from ta2ye0n ta2ye0n is a code owner

Assignees

@KimTaeO KimTaeO

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

existByDateAndPeriodsAndClub κ΅¬ν˜„
2 participants
@KimTaeO @ani2689