Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ” ํ…Œ์ด๋ธ” ์ด๋ฆ„ users๋กœ ๋ณ€๊ฒฝ #327

Merged
merged 1 commit into from
May 28, 2024

Conversation

Huuuunee
Copy link
Member

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

PR์„ ํ•˜๊ฒŒ ๋œ ๋ฌธ์ œ์ƒํ™ฉ, ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”์— ๋Œ€ํ•ด์„œ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”!
์„œ๋ฒ„ ๋ฐฐํฌ ์ค‘ MYSQL์˜ user๊ฐ€ ์˜ˆ์•ฝ์–ด๋กœ ์„ค์ •๋˜์–ด ํ…Œ์ด๋ธ”์ด ๋งŒ๋“ค์–ด์ง€์ง€ ์•Š๋Š” ์ด์Šˆ ๋ฐœ์ƒ์œผ๋กœ ์ธํ•ด users๋กœ ๋ณ€๊ฒฝ.
ํผ๋ธ”๋ฆฌ์‹ฑ์˜ ๊ฒฝ์šฐ ์Šคํฌ๋ฆฐ์ƒท/๋™์˜์ƒ๋„ ์ถ”๊ฐ€ํ•ด์ฃผ๋ฉด ์ข‹์•„์š”!

Resolves: #{์ด์Šˆ๋ฒˆํ˜ธ}

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

PR์—์„œ ํ•œ ์ž‘์—…์„ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”!
์œ ์ € ์—”ํ‹ฐํ‹ฐ์˜ @table(name = "user") => @table(name = "users")๋กœ ๋ณ€๊ฒฝ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

๊ตฌํ˜„ ์‹œ์— ๊ณ ๋ฏผ์ด์—ˆ๋˜ ์ ๋“ค ํ˜น์€ ํŠน์ • ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์˜๋„๊ฐ€ ์žˆ์—ˆ๋‹ค๋ฉด PR ๋ฆฌ๋ทฐ์˜ ์ดํ•ด๋ฅผ ๋•๊ธฐ ์œ„ํ•ด ์„œ์ˆ ํ•ด์ฃผ์„ธ์š”!

๋˜ํ•œ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ํŠน์ • ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์ง‘์ค‘ ํ˜น์€ ์ฝ”๋ฉ˜ํŠธ ํ˜น์€ ์งˆ๋ฌธ์„ ์š”์ฒญํ•˜๋Š” ๊ฒฝ์šฐ์— ์ž‘์„ฑํ•˜๋ฉด ์ข‹์•„์š”!

e.g. ์ž‘์—…์„ ๋๋‚ด์•ผํ•  ์‹œ๊ฐ„์ด ์–ผ๋งˆ ์—†์–ด ํ™•์žฅ์„ฑ๋ณด๋‹ค๋Š” ๋™์ž‘์„ ์œ„์ฃผ๋กœ ๋งŒ๋“ค์—ˆ์–ด์š”! ๊ฐ์•ˆํ•˜๊ณ  ๋ฆฌ๋ทฐํ•ด์ฃผ์„ธ์š”!

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@Huuuunee Huuuunee added the 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! label May 28, 2024
@Huuuunee Huuuunee self-assigned this May 28, 2024
@Huuuunee Huuuunee removed the request for review from 100Seung-Min May 28, 2024 14:12
@Huuuunee Huuuunee merged commit 3fda11c into develop May 28, 2024
1 check passed
@Huuuunee Huuuunee deleted the refac/table-user branch May 28, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants