Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically modify the render distance for dropped items entities to preserve performance #653

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Dynamically modify the render distance for dropped items entities to preserve performance #653

merged 7 commits into from
Oct 16, 2024

Conversation

Alexdoru
Copy link
Member

@Alexdoru Alexdoru commented Oct 11, 2024 •
edited
Loading

Sodium changes the render distance of all entites including dropped items and that can cause a big performance hit when lots of items are on the ground.

In this PR I :

  • set the dropped item render distance to 32 blocks
  • add a feature to dynamically modifies the render distance of dropped items entities when the game is rendering too many dropped item
  • you can change in game the amount of dropped item rendered

@Dream-Master Dream-Master requested review from mitchej123 and a team October 11, 2024 18:50
@Alexdoru Alexdoru changed the title Restore the dropped item render distance limit to 16 blocks Dynamically modifies the render distance of dropped items entities to preserve performance Oct 15, 2024
@Alexdoru Alexdoru changed the title Dynamically modifies the render distance of dropped items entities to preserve performance Dynamically modify the render distance for dropped items entities to preserve performance Oct 15, 2024
@mitchej123 mitchej123 merged commit 6cf119d into master Oct 16, 2024
1 check passed
@mitchej123 mitchej123 deleted the entity-items branch October 16, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchej123 mitchej123 mitchej123 approved these changes

@Cleptomania Cleptomania Awaiting requested review from Cleptomania

@Caedis Caedis Awaiting requested review from Caedis

@embeddedt embeddedt Awaiting requested review from embeddedt

@ah-OOG-ah ah-OOG-ah Awaiting requested review from ah-OOG-ah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexdoru @mitchej123