Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tooltiops for shader options #705

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

TotallyNotOndre
Copy link
Contributor

image
fix #690

@Cleptomania
Copy link
Member

For some reason I can't capture a screenshot of these tooltips, but the tooltip positioning seems to go from the bottom of the screen. If you turn GUI scale down to like 2 or 3 it's apparent. That problem isn't really a problem with this PR, but it would be nice to fix that at the same time if possible?

@TotallyNotOndre
Copy link
Contributor Author

should i just draw it at mouse location?

@Cleptomania
Copy link
Member

I toyed with it, and changing

final int y = this.height - (panelHeight + 4);

to

int y = mouseY + 10;
if (y + panelheight >= (this.height - 4)) y = this.height - (panelHeight + 4);

This looks much better in my opinion, but I checked modern Iris and it actually still always draws the tooltip at the bottom too. So not sure what we should do there. Personally I like the Y level being based on the mouse position.

@TotallyNotOndre
Copy link
Contributor Author

looks more readable than if it just follows the cursor

@Cleptomania
Copy link
Member

I think we can just merge this as is, it's in line with what Iris is doing in modern, if we wanna change the positioning later we can revisit it

@TotallyNotOndre
Copy link
Contributor Author

ok then

@Cleptomania Cleptomania enabled auto-merge (squash) October 31, 2024 16:01
@Cleptomania Cleptomania merged commit 979ad34 into GTNewHorizons:master Oct 31, 2024
1 check passed
@TotallyNotOndre TotallyNotOndre deleted the patch-1 branch October 31, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Shaders] Iris options lack tooltip support
2 participants