Only clear the translucency sorting render queue when we're not rendering shadows. #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring shadows. This matches the behaviour of the rebuild queues. Unconditionally clearing it in reset() does not work because sorting tasks are only spawned when not rendering shadows, and this combined with the fact that SodiumWorldRenderer spawns tasks (chunkRenderManager.updateChunks()) *before* updating the render queues (chunkRenderManager.update) would result in translucency sorting never being triggered.
mitchej123
approved these changes
Dec 16, 2024
|
I'm pretty sure this is good but I wanna get embeddedt's opinion before merging this. |
mitchej123
changed the title
embeddedt
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ring shadows.
This matches the behaviour of the rebuild queues. Unconditionally clearing it in reset() does not work because sorting tasks are only spawned when not rendering shadows, and this combined with the fact that SodiumWorldRenderer spawns tasks (chunkRenderManager.updateChunks) before updating the render queues (chunkRenderManager.update) would result in translucency sorting never being triggered.
This is the third in a series of 3 PRs that fixes translucency sorting with shaders. The first two were #796 and #797. With this, translucency sorting works and is correctly updated on camera motion.