Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose texture updates to API #805

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Expose texture updates to API #805

merged 5 commits into from
Dec 20, 2024

Conversation

CookieBrigade
Copy link
Contributor

@CookieBrigade CookieBrigade commented Dec 19, 2024 •
edited
Loading

Simple method so other mods can add compat.

@CookieBrigade CookieBrigade marked this pull request as draft December 19, 2024 02:47
@CookieBrigade CookieBrigade marked this pull request as ready for review December 19, 2024 15:57
@CookieBrigade CookieBrigade marked this pull request as draft December 19, 2024 16:09
@CookieBrigade CookieBrigade marked this pull request as ready for review December 19, 2024 17:03
@Dream-Master Dream-Master requested review from mitchej123 and a team December 19, 2024 19:32
embeddedt
embeddedt approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@embeddedt embeddedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I do think Angelica should also try to support more mods out of the box with cleverer detection hooks, rather than requiring explicit compat.

@mitchej123 mitchej123 merged commit ead4e11 into GTNewHorizons:master Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embeddedt embeddedt embeddedt approved these changes

@mitchej123 mitchej123 Awaiting requested review from mitchej123

@Cleptomania Cleptomania Awaiting requested review from Cleptomania

@Caedis Caedis Awaiting requested review from Caedis

@ah-OOG-ah ah-OOG-ah Awaiting requested review from ah-OOG-ah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CookieBrigade @embeddedt @mitchej123