Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crystalizer to produce Lapotron Chip and Energy Chip, with recipes in different voltage tier. #2858

Draft
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

koiNoCirculation
Copy link
Contributor

@koiNoCirculation koiNoCirculation commented Aug 10, 2024

Controller block for Large Crystalizer. Brought by Twist Space Technology.
Creating crystals with the power of force field, which can produce lapotron and energy chips with far lower cost.
It can process 16 items at a time, upgrading Field Containment casing can reduce power cost and recipe time
The Field Containment block has 2 types, center and surrounding. The tier of center block must be higher than surrounding block.
The machine is sensitive to pollution. When the pollution is greater than 500000, it will refuse to work.
Putting it into clean-room can protect it from heavy pollution if you can't find a clean place for this machine.
All recipes are based on chances, putting the machine on space station can obtain 10% more chance of success.
The efficiency of the machine grows as it runs. It will take up to 9 hours to get full efficiency.
With full efficiency, extra 30% of output is produced and the chance of recipes become 100%.
When using containment casing of higher tier, it will cost less time to become 100% efficient.
Right click controller with a screwdriver to enable certainty mode.
Can process recipes without chance with lower speed. Upgrading field casing can reduce penalty.

Overview:
image
Controller and containment field blocks(some of them missing material or recipe, will work on that.)
image
Recipes:
Controller
92a6bc7f913ebfd128043a79c2a1e2f3
HV Containment Field Block
image
EV Containment Field Block
image
IV Containment Field Block
image
LuV Containment Field Block(Recipe added by twist space technology, will rework on that material, and add a default recipe in GT for that)
497de8f940a08458076151ecc5d6944bZPM Containment Field Block
image
UV Containment Field Block
image

Tectech Containment Field Block
d7fc460a33069b916e853ae91ef384af
Tectech Ultimate Containment Field Block(Recipe is from TST, may need to re-add a new recipe)
d060001b4aad8bf201becdc08af038e9

Recipes:
Perfect Lapotron Crystal 1:
d6de196386c7da99e3494d14a7ad2114
Costs a whole day with HV voltage. Only this recipe needs to be placed in a space station to work.
image
Running on ZPM volt with certainty mode.

Place crystals in forge hammer to earn seeds.
02d9e67cd5e4b4877e0031cf0f0611ddPerfect Lapotron Crystal 2:
7116f5cec1efd009c482c44883853d22
90d013817b548759cd0a412436db40d3

Needs 4 UEV circuits, lapotron-Infinity mixture, quantum alloy and grade 8 purified water.

Place it in laser engraver to get lapotron chips.
1aae8418c49a2df481e95f9d584271a7

Crude Lapotron Crystal:
616635f6521f279b0a38329fe437c3d2
69fbac0ff5443d0ebe77b080a2142801
Needs 8 LuV circuits, Lapotron-Naquadah mixture, arcanite and grade 5 purified water.
Laser engraver output:
741bd0368dc0d852bb5433fca99cbe16
Hammer:
7c766eca0a574f4063195bca58a2e82b

Stable Lapotron Crystal:
b573a2dc1ae2ca021e63fea53c7e8330
63a3dc58d179a4db04a36764c92d2135
Needs 8 ZPM circuits, Lapotron-Naquadria mixture, HeLiCoPtEr and grade 6 purified water.
Laser engraver output:
acd186799b4e6bc552954bb6ede7f65a
Hammer:
17f9a4568fde47994b136bd324bfa671

Good Lapotron Crystal
d7c58c644891b5425b169b3c3b3750ef
3c477ecb2944203d17ed939caa8e13a0
Needs 4 UHV circuits, Lapotron-Amercium mixture, octi-iron and grade 7 purified water.
Laser engraver output:
6c017724904282d3cdd341d6913030b7
Hammer:
56d4b905e45d4e3f442dc292ede95545

Perfect Ruby Crystal:
8394a1c808dce6325b5d8bb4c2b92046
Needs LuV circuit, arcanite and grade 3 purified water.
Laser:
aad2ab7dad095e4f81b626549f127b82

@koiNoCirculation
Copy link
Contributor Author

@Dream-Master Any suggestions?

import gregtech.common.tileentities.machines.multi.GT_MetaTileEntity_TranscendentPlasmaMixer;
import gregtech.common.tileentities.machines.multi.GT_MetaTileEntity_VacuumFreezer;
import gregtech.common.tileentities.machines.multi.GT_MetaTileEntity_WormholeGenerator;
import gregtech.common.tileentities.machines.multi.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use star imports

GT_HatchElement.OutputBus,
GT_HatchElement.InputHatch,
GT_HatchElement.OutputHatch,
GT_HatchElement.Energy.or(GT_HatchElement.ExoticEnergy))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is lpf replacement for autoclave then it shouldnt allow laser/multiamp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is lpf replacement for autoclave then it shouldnt allow laser/multiamp

MultiAmp/Laser is for UIV+ Tier. It's to avoid using too much of machines in end game. Or if needed I can bring a larger structure(that in Twist) for lasered autoclave.
That recipe brought by TST uses UIV + UEV field generator, that means the laser can only be enable in very late game.

Copy link
Contributor

@NotAPenguin0 NotAPenguin0 Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from how it is in Twist, I don't think we should allow this scaling of a single machine for an entire process in base GTNH

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IV GT++ multis and their replacements will not have lasers, there is a general agreement on this, even if it's some upgrade that's locked later in progression. Since this is meant to be one of the multis to replace the LPF, it can't have lasers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Only when this thing is placed in structure, the laser is enabled. The recipe need some rework to fit GTNH it self.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IV GT++ multis and their replacements will not have lasers, there is a general agreement on this, even if it's some upgrade that's locked later in progression.

We've already had an electromagnet multi with multiamp upgrade though

Copy link
Contributor

@FourIsTheNumber FourIsTheNumber Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IV GT++ multis and their replacements will not have lasers, there is a general agreement on this, even if it's some upgrade that's locked later in progression.

We've already had an electromagnet multi with multiamp upgrade though

Specifically not lasers. Huge difference.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiamp is not nearly powerful as laser though, and 64A UMV is the same power as slapping 8 UXV energy hatches on a multi which you can already do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from how it is in Twist, I don't think we should allow this scaling of a single machine for an entire process in base GTNH

Well, in fact, the LPF is that one used in the entire game since IV, and players need tons of them in lategame. So do you mean that there should another kinds of machine for production power in late game, rather than just a replacement for LPF?

@NotAPenguin0
Copy link
Contributor

Balance and other issues aside, there's also another autoclave multiblock in the works/nearly finished by @Volence, with a lot less extreme mechanics. We definitely need to look at which of these should be implemented further or if ideas should be combined somehow.

@Dream-Master Dream-Master requested a review from a team August 10, 2024 12:22
@Steelux8
Copy link
Contributor

In my opinion, less extreme is better since this is an IV multi. This looks far too complex to be a simple LPF replacement for IV autoclaving.

@koiNoCirculation koiNoCirculation changed the title Add crystalizer to replace LPF Planning a new Lapotron factory(or some other) rather than generic autoclave Aug 10, 2024
@Zenovis
Copy link

Zenovis commented Aug 11, 2024

I'd like to comment on this multiblock and give my opinion, as it does look very cool and unique. I agree that this is too complex for a simple replacement of an lpf autoclave, and since it was clearly inspired by twist I believe the original intention is to make it simpler to mass produce lapotron chips for batteries.

Twist adds the Crystalline Infinitier, a "mega" autoclave at UEV which unlocks a significantly cheaper and a dual step recipe for lapotron chips. A single UEV capacitor takes 2.3M engraved lapotron chips, which are very tedious, bulky, and time intensive to craft. A UIV capacitor takes ~18M. If this multi does have a place in the pack I believe it would be to add an optional, cheaper, and faster alternative to make lapotron chips in bulk, gated somewhere around UV-UHV. Perhaps a recipe that takes some of the raw inputs for lapotron chips (lapis dust, energium dust, molten vibrant alloy), etc. (or upgraded inputs, similar to circuits) and can make the lapotron crystals in a single step or an "upgraded" lapotron crystal that laser engraves into 32/64 chips instead of 3.

It's rather hard to tell based on the OP but I believe this multi is primarily focused on just energy / lapotron crystals. I could be wrong.

image

@koiNoCirculation
Copy link
Contributor Author

I'd like to comment on this multiblock and give my opinion, as it does look very cool and unique. I agree that this is too complex for a simple replacement of an lpf autoclave, and since it was clearly inspired by twist I believe the original intention is to make it simpler to mass produce lapotron chips for batteries.

Twist adds the Crystalline Infinitier, a "mega" autoclave at UEV which unlocks a significantly cheaper and a dual step recipe for lapotron chips. A single UEV capacitor takes 2.3M engraved lapotron chips, which are very tedious, bulky, and time intensive to craft. A UIV capacitor takes ~18M. If this multi does have a place in the pack I believe it would be to add an optional, cheaper, and faster alternative to make lapotron chips in bulk, gated somewhere around UV-UHV. Perhaps a recipe that takes some of the raw inputs for lapotron chips (lapis dust, energium dust, molten vibrant alloy), etc. (or upgraded inputs, similar to circuits) and can make the lapotron crystals in a single step or an "upgraded" lapotron crystal that laser engraves into 32/64 chips instead of 3.

It's rather hard to tell based on the OP but I believe this multi is primarily focused on just energy / lapotron crystals. I could be wrong.

image

It can be progressive and get unlocked in LuV/ZPM, integrated with new clean water line.
I need some time to redesign it.

@koiNoCirculation
Copy link
Contributor Author

I'd like to comment on this multiblock and give my opinion, as it does look very cool and unique. I agree that this is too complex for a simple replacement of an lpf autoclave, and since it was clearly inspired by twist I believe the original intention is to make it simpler to mass produce lapotron chips for batteries.

Twist adds the Crystalline Infinitier, a "mega" autoclave at UEV which unlocks a significantly cheaper and a dual step recipe for lapotron chips. A single UEV capacitor takes 2.3M engraved lapotron chips, which are very tedious, bulky, and time intensive to craft. A UIV capacitor takes ~18M. If this multi does have a place in the pack I believe it would be to add an optional, cheaper, and faster alternative to make lapotron chips in bulk, gated somewhere around UV-UHV. Perhaps a recipe that takes some of the raw inputs for lapotron chips (lapis dust, energium dust, molten vibrant alloy), etc. (or upgraded inputs, similar to circuits) and can make the lapotron crystals in a single step or an "upgraded" lapotron crystal that laser engraves into 32/64 chips instead of 3.

It's rather hard to tell based on the OP but I believe this multi is primarily focused on just energy / lapotron crystals. I could be wrong.

image

Well, actually it's not simply a UEV machine, that block at center needs Transcendent metal so it's UIV mega :(

@koiNoCirculation
Copy link
Contributor Author

I'd like to comment on this multiblock and give my opinion, as it does look very cool and unique. I agree that this is too complex for a simple replacement of an lpf autoclave, and since it was clearly inspired by twist I believe the original intention is to make it simpler to mass produce lapotron chips for batteries.

Twist adds the Crystalline Infinitier, a "mega" autoclave at UEV which unlocks a significantly cheaper and a dual step recipe for lapotron chips. A single UEV capacitor takes 2.3M engraved lapotron chips, which are very tedious, bulky, and time intensive to craft. A UIV capacitor takes ~18M. If this multi does have a place in the pack I believe it would be to add an optional, cheaper, and faster alternative to make lapotron chips in bulk, gated somewhere around UV-UHV. Perhaps a recipe that takes some of the raw inputs for lapotron chips (lapis dust, energium dust, molten vibrant alloy), etc. (or upgraded inputs, similar to circuits) and can make the lapotron crystals in a single step or an "upgraded" lapotron crystal that laser engraves into 32/64 chips instead of 3.

It's rather hard to tell based on the OP but I believe this multi is primarily focused on just energy / lapotron crystals. I could be wrong.

image

In twist it's also used to make solar panels, but probably not here for now. Because devs hate solar.

@koiNoCirculation koiNoCirculation changed the title Planning a new Lapotron factory(or some other) rather than generic autoclave Add Crystalizer to produce Lapotron Chip and Energy Chip, with recipes in different voltage tier. Aug 14, 2024
@koiNoCirculation koiNoCirculation marked this pull request as ready for review August 14, 2024 02:37
@koiNoCirculation
Copy link
Contributor Author

@Dream-Master Rework is done. It is now a machine that concentrates on making Lapotron chips and Energy Chips since LuV/ZPM.

@Hikari1nVoid
Copy link

like we discussed b4 the texture is unacceptable.

@EnderProyects
Copy link

EnderProyects commented Aug 14, 2024

I knowm I´m not the one that thinks that some blocks textures are very ugly, also the items texture seems to be out of place

@joshaup1999
Copy link

I’ve got a couple of concerns about this being added, the run time component of the multi so it increases the rng chances sounds like an annoying mechanic to deal with, more so if you have power outages and I just feel like it’s not a fun game mechanic of let’s have a machine require a full day to get upto 100% efficiency

Space station component is completely stupid, they’re massively laggy in game, pain to move around due to GC gravity and it also adds no extra depth to the game par having to launch a rocket and slap down a quantum bridge

@koiNoCirculation
Copy link
Contributor Author

@Dream-Master I think it's ready to be reviewed again.

(cherry picked from commit f7613d0)
@Dream-Master
Copy link
Member

@NotAPenguin0
Copy link
Contributor

I'll share some of my thoughts on this here, because I think this multi does have potential to become something interesting.

  • Lapotrons are overused in their current form. You start making them in EV/IV and they never change, you just need exponentially more of them every tier. This in itself is a design flaw I think, higher tiers should use higher tier materials. This multiblock seems to address that by adding higher tier lapotron base mixture materials that can be processed for more lapotrons as a result. I think this is not necessarily a bad approach, since it keeps compatibility with old setups more.
  • Another, more drastic solution to the lapotron problem would be to create higher tier crystals that are not really related to lapotrons anymore. This opens up many more possibilities for interesting mechanics, and can still use some of the lines in this multiblock, just with the different lapotron tiers as output.
  • While some of the mechanics in the multi are cool, I'm not sure how I feel about the low gravity requirement. It seems to just be there as an annoyance ("Now fly to your space dim, set up this multi to run a recipe once and then come back"). Space requirement is in my opinion only a good thing if it's for something semi-permanent and if the dimension would be actually playable (lag, movement).
  • I'm sorry to say this, and by no means do I want to invalidate the work @koiNoCirculation has put into this, but the current implementation is very unpolished and can't make it into the pack. This could be a bit of a presentation issue (rainy screenshot of the multiblock structure for example), but even so the structure and textures are very rough and need to be updated before this can be considered for merging I think.

All in all, I think this PR provides a good starting point for further discussion around adjustments for lapotron crystals. Throwing out all the work done here seems like a waste, so this can definitely be used as a base for ideas and implementation of (a) new lapotron line(s) that can scale to endgame at higher resource costs.

drawEnergyInfo(recipeInfo);
drawDurationInfo(recipeInfo);
drawSpecialInfo(recipeInfo);
drawMetadataInfo(recipeInfo);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recipe owner is meant to be debug purpose and does not get displayed by default. Please don't override just to remove it.

}

@Override
public void reInit() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this override?

}
}

public static final RecipeMap<RecipeMapBackendCrystalizer> CRYSTALIZER_RECIPES = RecipeMapBuilder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please place this at RecipeMaps just like others.

enableChance = !enableChance;
}

public static void initializeRecipes() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're accessing NHCore items, these recipes probably should be placed there instead.

@NotNull
@Override
protected CheckRecipeResult validateRecipe(@NotNull GT_Recipe recipe) {
int pollution = GT_Pollution.getPollution(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use getPollution(IGregTechTileEntity) instead

return new GT_ParallelHelper() {

@Override
protected void calculateItemOutputs(ItemStack[] truncatedItemOutputs) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe can you make setCustomItemOutputCalculation take argument like this?

public interface ItemOutputCalculation {
    ItemStack[] calculate(int parallel, Supplier<ItemStack[]> fallback);
}

This way you can call super.calculateItemOutputs inside setCustomItemOutputCalculation, without worrying about setting the rest of properties.

@@ -515,6 +516,7 @@ GT5U.gui.text.cleanroom_running=§aCleanroom running
GT5U.gui.text.no_machine=§7No valid processing machine
GT5U.gui.text.machine_mismatch=§7Machine doesn't match to locked recipe
GT5U.gui.text.high_gravity=§7Recipe needs low gravity
GT5U.gui.text.too_much_pollution=§7Please reduce pollution under 500k or put it into cleanroom.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, error message should state why the recipe failed, not how to fix it. You can put requirements in machine tooltip or something.

@Hikari1nVoid
Copy link

Hikari1nVoid commented Aug 27, 2024

I'll share some of my thoughts on this here, because I think this multi does have potential to become something interesting.

  • Lapotrons are overused in their current form. You start making them in EV/IV and they never change, you just need exponentially more of them every tier. This in itself is a design flaw I think, higher tiers should use higher tier materials. This multiblock seems to address that by adding higher tier lapotron base mixture materials that can be processed for more lapotrons as a result. I think this is not necessarily a bad approach, since it keeps compatibility with old setups more.
  • Another, more drastic solution to the lapotron problem would be to create higher tier crystals that are not really related to lapotrons anymore. This opens up many more possibilities for interesting mechanics, and can still use some of the lines in this multiblock, just with the different lapotron tiers as output.
  • While some of the mechanics in the multi are cool, I'm not sure how I feel about the low gravity requirement. It seems to just be there as an annoyance ("Now fly to your space dim, set up this multi to run a recipe once and then come back"). Space requirement is in my opinion only a good thing if it's for something semi-permanent and if the dimension would be actually playable (lag, movement).
  • I'm sorry to say this, and by no means do I want to invalidate the work @koiNoCirculation has put into this, but the current implementation is very unpolished and can't make it into the pack. This could be a bit of a presentation issue (rainy screenshot of the multiblock structure for example), but even so the structure and textures are very rough and need to be updated before this can be considered for merging I think.

All in all, I think this PR provides a good starting point for further discussion around adjustments for lapotron crystals. Throwing out all the work done here seems like a waste, so this can definitely be used as a base for ideas and implementation of (a) new lapotron line(s) that can scale to endgame at higher resource costs.

LSCs are bring spammed because PSS simply sucks after nerf.Let alone LESU.Adding extra cost brings nothing but tedious grind in tiers that already have bunch of things to do.

@FourIsTheNumber
Copy link
Contributor

Basically second what NotAPenguin said. This is a good baseline for some more radical changes to lapotrons, which are quite rough in their current implementation. I'm interested in this multi more as a way to generate advanced materials for advanced batteries than I am as a way to facilitate making huge numbers of existing chips. This would require a larger-scale rework that I personally would not mind doing some design work for, and I would prefer to merge this multi as a part of that.

If we are considering merging this, it does need a pass from texture artists - we have a lot of talented people on the discord!

@boubou19 boubou19 added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Aug 29, 2024
@Dream-Master Dream-Master marked this pull request as draft August 29, 2024 16:33
@koiNoCirculation
Copy link
Contributor Author

Basically second what NotAPenguin said. This is a good baseline for some more radical changes to lapotrons, which are quite rough in their current implementation. I'm interested in this multi more as a way to generate advanced materials for advanced batteries than I am as a way to facilitate making huge numbers of existing chips. This would require a larger-scale rework that I personally would not mind doing some design work for, and I would prefer to merge this multi as a part of that.

If we are considering merging this, it does need a pass from texture artists - we have a lot of talented people on the discord!

If you want to improve that, it's welcomed. Thank you for considering my idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze.
Projects
None yet
Development

Successfully merging this pull request may close these issues.