-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Crystalizer to produce Lapotron Chip and Energy Chip, with recipes in different voltage tier. #2858
base: master
Are you sure you want to change the base?
Add Crystalizer to produce Lapotron Chip and Energy Chip, with recipes in different voltage tier. #2858
Conversation
@Dream-Master Any suggestions? |
import gregtech.common.tileentities.machines.multi.GT_MetaTileEntity_TranscendentPlasmaMixer; | ||
import gregtech.common.tileentities.machines.multi.GT_MetaTileEntity_VacuumFreezer; | ||
import gregtech.common.tileentities.machines.multi.GT_MetaTileEntity_WormholeGenerator; | ||
import gregtech.common.tileentities.machines.multi.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use star imports
GT_HatchElement.OutputBus, | ||
GT_HatchElement.InputHatch, | ||
GT_HatchElement.OutputHatch, | ||
GT_HatchElement.Energy.or(GT_HatchElement.ExoticEnergy)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is lpf replacement for autoclave then it shouldnt allow laser/multiamp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is lpf replacement for autoclave then it shouldnt allow laser/multiamp
MultiAmp/Laser is for UIV+ Tier. It's to avoid using too much of machines in end game. Or if needed I can bring a larger structure(that in Twist) for lasered autoclave.
That recipe brought by TST uses UIV + UEV field generator, that means the laser can only be enable in very late game.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from how it is in Twist, I don't think we should allow this scaling of a single machine for an entire process in base GTNH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IV GT++ multis and their replacements will not have lasers, there is a general agreement on this, even if it's some upgrade that's locked later in progression. Since this is meant to be one of the multis to replace the LPF, it can't have lasers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IV GT++ multis and their replacements will not have lasers, there is a general agreement on this, even if it's some upgrade that's locked later in progression.
We've already had an electromagnet multi with multiamp upgrade though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IV GT++ multis and their replacements will not have lasers, there is a general agreement on this, even if it's some upgrade that's locked later in progression.
We've already had an electromagnet multi with multiamp upgrade though
Specifically not lasers. Huge difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiamp is not nearly powerful as laser though, and 64A UMV is the same power as slapping 8 UXV energy hatches on a multi which you can already do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from how it is in Twist, I don't think we should allow this scaling of a single machine for an entire process in base GTNH
Well, in fact, the LPF is that one used in the entire game since IV, and players need tons of them in lategame. So do you mean that there should another kinds of machine for production power in late game, rather than just a replacement for LPF?
Balance and other issues aside, there's also another autoclave multiblock in the works/nearly finished by @Volence, with a lot less extreme mechanics. We definitely need to look at which of these should be implemented further or if ideas should be combined somehow. |
In my opinion, less extreme is better since this is an IV multi. This looks far too complex to be a simple LPF replacement for IV autoclaving. |
I'd like to comment on this multiblock and give my opinion, as it does look very cool and unique. I agree that this is too complex for a simple replacement of an lpf autoclave, and since it was clearly inspired by twist I believe the original intention is to make it simpler to mass produce lapotron chips for batteries. Twist adds the Crystalline Infinitier, a "mega" autoclave at UEV which unlocks a significantly cheaper and a dual step recipe for lapotron chips. A single UEV capacitor takes 2.3M engraved lapotron chips, which are very tedious, bulky, and time intensive to craft. A UIV capacitor takes ~18M. If this multi does have a place in the pack I believe it would be to add an optional, cheaper, and faster alternative to make lapotron chips in bulk, gated somewhere around UV-UHV. Perhaps a recipe that takes some of the raw inputs for lapotron chips (lapis dust, energium dust, molten vibrant alloy), etc. (or upgraded inputs, similar to circuits) and can make the lapotron crystals in a single step or an "upgraded" lapotron crystal that laser engraves into 32/64 chips instead of 3. It's rather hard to tell based on the OP but I believe this multi is primarily focused on just energy / lapotron crystals. I could be wrong. |
It can be progressive and get unlocked in LuV/ZPM, integrated with new clean water line. |
Well, actually it's not simply a UEV machine, that block at center needs Transcendent metal so it's UIV mega :( |
In twist it's also used to make solar panels, but probably not here for now. Because devs hate solar. |
@Dream-Master Rework is done. It is now a machine that concentrates on making Lapotron chips and Energy Chips since LuV/ZPM. |
like we discussed b4 the texture is unacceptable. |
I knowm I´m not the one that thinks that some blocks textures are very ugly, also the items texture seems to be out of place |
I’ve got a couple of concerns about this being added, the run time component of the multi so it increases the rng chances sounds like an annoying mechanic to deal with, more so if you have power outages and I just feel like it’s not a fun game mechanic of let’s have a machine require a full day to get upto 100% efficiency Space station component is completely stupid, they’re massively laggy in game, pain to move around due to GC gravity and it also adds no extra depth to the game par having to launch a rocket and slap down a quantum bridge |
@Dream-Master I think it's ready to be reviewed again. |
I'll share some of my thoughts on this here, because I think this multi does have potential to become something interesting.
All in all, I think this PR provides a good starting point for further discussion around adjustments for lapotron crystals. Throwing out all the work done here seems like a waste, so this can definitely be used as a base for ideas and implementation of (a) new lapotron line(s) that can scale to endgame at higher resource costs. |
drawEnergyInfo(recipeInfo); | ||
drawDurationInfo(recipeInfo); | ||
drawSpecialInfo(recipeInfo); | ||
drawMetadataInfo(recipeInfo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recipe owner is meant to be debug purpose and does not get displayed by default. Please don't override just to remove it.
} | ||
|
||
@Override | ||
public void reInit() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this override?
} | ||
} | ||
|
||
public static final RecipeMap<RecipeMapBackendCrystalizer> CRYSTALIZER_RECIPES = RecipeMapBuilder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please place this at RecipeMaps
just like others.
enableChance = !enableChance; | ||
} | ||
|
||
public static void initializeRecipes() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're accessing NHCore items, these recipes probably should be placed there instead.
@NotNull | ||
@Override | ||
protected CheckRecipeResult validateRecipe(@NotNull GT_Recipe recipe) { | ||
int pollution = GT_Pollution.getPollution( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use getPollution(IGregTechTileEntity)
instead
return new GT_ParallelHelper() { | ||
|
||
@Override | ||
protected void calculateItemOutputs(ItemStack[] truncatedItemOutputs) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe can you make setCustomItemOutputCalculation
take argument like this?
public interface ItemOutputCalculation {
ItemStack[] calculate(int parallel, Supplier<ItemStack[]> fallback);
}
This way you can call super.calculateItemOutputs
inside setCustomItemOutputCalculation
, without worrying about setting the rest of properties.
@@ -515,6 +516,7 @@ GT5U.gui.text.cleanroom_running=§aCleanroom running | |||
GT5U.gui.text.no_machine=§7No valid processing machine | |||
GT5U.gui.text.machine_mismatch=§7Machine doesn't match to locked recipe | |||
GT5U.gui.text.high_gravity=§7Recipe needs low gravity | |||
GT5U.gui.text.too_much_pollution=§7Please reduce pollution under 500k or put it into cleanroom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, error message should state why the recipe failed, not how to fix it. You can put requirements in machine tooltip or something.
LSCs are bring spammed because PSS simply sucks after nerf.Let alone LESU.Adding extra cost brings nothing but tedious grind in tiers that already have bunch of things to do. |
Basically second what NotAPenguin said. This is a good baseline for some more radical changes to lapotrons, which are quite rough in their current implementation. I'm interested in this multi more as a way to generate advanced materials for advanced batteries than I am as a way to facilitate making huge numbers of existing chips. This would require a larger-scale rework that I personally would not mind doing some design work for, and I would prefer to merge this multi as a part of that. If we are considering merging this, it does need a pass from texture artists - we have a lot of talented people on the discord! |
If you want to improve that, it's welcomed. Thank you for considering my idea. |
Controller block for Large Crystalizer. Brought by Twist Space Technology.
Creating crystals with the power of force field, which can produce lapotron and energy chips with far lower cost.
It can process 16 items at a time, upgrading Field Containment casing can reduce power cost and recipe time
The Field Containment block has 2 types, center and surrounding. The tier of center block must be higher than surrounding block.
The machine is sensitive to pollution. When the pollution is greater than 500000, it will refuse to work.
Putting it into clean-room can protect it from heavy pollution if you can't find a clean place for this machine.
All recipes are based on chances, putting the machine on space station can obtain 10% more chance of success.
The efficiency of the machine grows as it runs. It will take up to 9 hours to get full efficiency.
With full efficiency, extra 30% of output is produced and the chance of recipes become 100%.
When using containment casing of higher tier, it will cost less time to become 100% efficient.
Right click controller with a screwdriver to enable certainty mode.
Can process recipes without chance with lower speed. Upgrading field casing can reduce penalty.
Overview:
Controller and containment field blocks(some of them missing material or recipe, will work on that.)
Recipes:
Controller
HV Containment Field Block
EV Containment Field Block
IV Containment Field Block
LuV Containment Field Block(Recipe added by twist space technology, will rework on that material, and add a default recipe in GT for that)
ZPM Containment Field Block
UV Containment Field Block
Tectech Containment Field Block
Tectech Ultimate Containment Field Block(Recipe is from TST, may need to re-add a new recipe)
Recipes:
Perfect Lapotron Crystal 1:
Costs a whole day with HV voltage. Only this recipe needs to be placed in a space station to work.
Running on ZPM volt with certainty mode.
Place crystals in forge hammer to earn seeds.
Perfect Lapotron Crystal 2:
Needs 4 UEV circuits, lapotron-Infinity mixture, quantum alloy and grade 8 purified water.
Place it in laser engraver to get lapotron chips.
Crude Lapotron Crystal:
Needs 8 LuV circuits, Lapotron-Naquadah mixture, arcanite and grade 5 purified water.
Laser engraver output:
Hammer:
Stable Lapotron Crystal:
Needs 8 ZPM circuits, Lapotron-Naquadria mixture, HeLiCoPtEr and grade 6 purified water.
Laser engraver output:
Hammer:
Good Lapotron Crystal
Needs 4 UHV circuits, Lapotron-Amercium mixture, octi-iron and grade 7 purified water.
Laser engraver output:
Hammer:
Perfect Ruby Crystal:
Needs LuV circuit, arcanite and grade 3 purified water.
Laser: