Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laser Meteor Miner #3116

Open
wants to merge 101 commits into
base: master
Choose a base branch
from
Open

Laser Meteor Miner #3116

wants to merge 101 commits into from

Conversation

zTotto
Copy link
Contributor

@zTotto zTotto commented Sep 8, 2024

Adds a proper miner for Blood Magic Meteors since the current solutions are somewhat lacky or annoying to setup. This multi mines all the blocks dropped by the meteor with fortune 3 but it can be easily modified by adding tiers.

preview-realizzato-con-clipchamp_Ho8tXcxC.mp4

The multiblock has a max range of 24 blocks but it gets dynamically lowered based on the meteorite size. It has a idle state when there's no meteor above the reference block, which is 32 blocks over the center of the multi's highest block.

working-realizzato-con-clipchamp_qnonMzKj.mp4

The multi also renders a laser from the top block of the coil line up to the upmost layer of the current meteor (the range of the laser is dynamic, the whole rendering can be disabled with a screwdriver).

If needed i could also add some kind of parallels and tiers, i was thinking about mining drones or liquids to cool down the lasers.
If the structure also needs some edits that's a quick edit, for example at the moment all the glass in the multi can be any tier but that's up to balancing, like it is in many multis with glass like the EEC or the MEBF.

(All the code was written after The Great Renaming™)

@zTotto
Copy link
Contributor Author

zTotto commented Sep 20, 2024

Raw ores can be easily changed, i could make it output directly the ore block (like the void miner does) or the crushed ore, although thaumcraft bores mining meteors still drop raw ores

Imo this is not a meteor buff but more of a QoL since arcane bores are painful to setup, there's no "thought" or anything like that (from my experience i just spammed them in a grid to cover all the meteor possible space, and that was just annoying, not a logistic challenge or anything like that)

Im totally fine with the feature freeze, im not in a hurry or anything

@boubou19
Copy link
Member

boubou19 commented Sep 20, 2024

Imo this is not a meteor buff but more of a QoL since arcane bores are painful to setup, there's no "thought" or anything like that (from my experience i just spammed them in a grid to cover all the meteor possible space, and that was just annoying, not a logistic challenge or anything like that)

If we strictly compare arcane bores and your multi, one is imperfect solution, the other is a perfect solution. You remove all any possible tradeoffs you had to do in order to exploit the arcane bores (how should you control it, do you want to spam this setup, etc). The issue is that while we agreed among the team to yeet massive tedium tasks, we aren't going to remove all the tedium from the game, especially if it induces thinking processes. QoL is a slippery slope, as what is acceptable for someone is annoying for the others, so with this logic of QoL, we can end up removing any challenge by turning anything into black boxes.

Also from what you said you only considered arcane bores, but there are other setups to explore to understand the gist of every automation, check their pros and cons. Only after that you can propose a solution.

Right know, this multi has potential to become THE way of progressing, ignoring miners in general. That would be annoying as ore meteors are supposed to be a side way of gathering ores.

@Dream-Master
Copy link
Member

Why not using Esentia as drill fluid and change the amimation to match more like a Arcane Bore 2.0 ?

@zTotto
Copy link
Contributor Author

zTotto commented Sep 20, 2024

I was thinking i could change some things, please tell me if you like them:

  • Make the multi consume centivis and some essentia (we can decide which one later, maybe perfodio or something like that), centivis or essentia scale with EU tier

  • Remove fortune and replace fortune tiers with efficiency tiers which lower the centivis or essentia required for each cycle, meaning that better pickaxe are more "magic attuned" and make the multi more "magic energy" efficient

@Ethryan
Copy link
Contributor

Ethryan commented Sep 20, 2024

I was thinking i could change some things, please tell me if you like them:

  • Make the multi consume centivis and some essentia (we can decide which one later, maybe perfodio or something like that), centivis or essentia scale with EU tier
  • Remove fortune and replace fortune tiers with efficiency tiers which lower the centivis or essentia required for each cycle, meaning that better pickaxe are more "magic attuned" and make the multi more "magic energy" efficient

1: in my opinion centivis is too easy to get a stable supply of for this to be realistic. Maybe the Astral Essentia or Space Essentia from GT for Thaumcraft is a better idea. That way that Essentia gets a nice use, from being useless.

2: why even have a fortune for the ores when that explicitly is set to be manual mining only. My opinion is to not give fortune for this, it’s powerful enough already without it.

@zTotto
Copy link
Contributor Author

zTotto commented Sep 20, 2024

I was thinking i could change some things, please tell me if you like them:

  • Make the multi consume centivis and some essentia (we can decide which one later, maybe perfodio or something like that), centivis or essentia scale with EU tier
  • Remove fortune and replace fortune tiers with efficiency tiers which lower the centivis or essentia required for each cycle, meaning that better pickaxe are more "magic attuned" and make the multi more "magic energy" efficient

1: in my opinion centivis is too easy to get a stable supply of for this to be realistic. Maybe the Astral Essentia or Space Essentia from GT for Thaumcraft is a better idea. That way that Essentia gets a nice use, from being useless.

2: why even have a fortune for the ores when that explicitly is set to be manual mining only. My opinion is to not give fortune for this, it’s powerful enough already without it.

I didn't know about the fortune stuff, i did it because i was looking at other miners and they had fortune (ore drills), now as i said i can remove it no problem, what do you think about the essentia efficiency bonus?

@Ethryan
Copy link
Contributor

Ethryan commented Sep 20, 2024

In my opinion it should need 1 of the essentia types to even run, maybe supply a different harder to get one in addition for a small 15 - 20 %, efficiency bonus.

But honestly, I’m crap at balancing stuff, so amount eaten and bonus given probably needs to be tweaked.

@NotAPenguin0
Copy link
Contributor

Feeding essentia doesn't really solve the issue at hand. Essentia is completely free to supply at this point in the pack, and the meteor miner will still easily be the best option for mining meteors without any major tradeoffs or downsides. Especially adding another 15-20% bonus on top would make it even more broken. The meteor miner should in my opinion be balanced against the power level of MBMs but specialized for mining meteors. This means

  • Similar speed to MBM
  • Similar power draw to MBM
  • Same yield as MBM
  • Slightly higher material cost for the convenience of it being specialized for meteors
  • Specialized for meteors, meaning it won't leave random blocks unmined like MBMs do.

This way it's a clear alternative to all other options, instead of simply being superior in every way.

@zTotto
Copy link
Contributor Author

zTotto commented Sep 21, 2024

At the moment the last 2 points are already true since it costs quite a lot more than an MBM (i could switch the T3 miner needed to craft it with a T4 miner)
Removing fortune would make the yield less than an MBM since that applies fortune to crashed ores and this wouldn't, fine by me
Power draw is not a problem, just a quick edit and its good
The speed could be balanced so that it mines 1 block at a time instead of a row, i could make the T2 mine a row at a time instead (since that's more advanced progression wise)

@NotAPenguin0
Copy link
Contributor

Just use the same drop code as MBMs, no need to complicate it further than that. I think it was already said that fortuned raw ores are not supposed to be used in automatic miners.

@zTotto
Copy link
Contributor Author

zTotto commented Sep 28, 2024

I'll update everything, im just busy these days (got a new dog hehe), probably will do everything before next week

@Dream-Master Dream-Master requested a review from a team September 28, 2024 14:26
@zTotto
Copy link
Contributor Author

zTotto commented Sep 30, 2024

I reworked the multi, now:

It mines just like an MBM (stone dust, crushed etc)

Differently from an MBM it doesnt always give 3x crushed, the T1 scales with fortune and with the tier 3 pickaxe (terra shatterer) it works like an MBM in terms of crushed ores. The T2 always has 3x crushed

The speed is like the MBM (i think like the T1 mbm) and the first tier mines one block at a time while the T2 mines one row at a time

@chochem chochem added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects Balance Change affecting balance. Requires admin approval before merging. new feature Add something new. Please explain in detail how it works. ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze.
Projects
None yet
Development

Successfully merging this pull request may close these issues.