Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some GT tools #3203

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Remove some GT tools #3203

wants to merge 20 commits into from

Conversation

Connor-Colenso
Copy link
Contributor

@Connor-Colenso Connor-Colenso commented Sep 15, 2024

Removes all GT pickaxes, shovels, hoes, axes and swords. Adds a new flint tool for each, that is a separate item. Each current item will be converted into a flint equivalent tool. Both axes and swords will retain their fire aspect enchant and new crafted tools will also retain this. Tested postea transforms and all seems to work fine. Will need some QB adjustments but nothing major. Main progression should be unchanged. I believe this is a good step to untangling the GT hell that is every item sharing an ID.

Removed the GT sense, plow, sickle and universal spade with no replacement, just because these tools are rather pointless. The sense head was used in one recipe, and I just replaced it with a plate of the same material, no substantial change in balance.

This should hopefully help speed up pack load (very) marginally as it will likely result in a reduction of 100s of random unused recipes for tons of useless GT tools with random materials. With the additional benefit of less confusion from new players clicking R on a GT pickaxe, to be met with 100s of recipes.

Copy link
Contributor

Warning: 2 uncommitted changes
#3204

@Connor-Colenso Connor-Colenso added the refactor For PRs rewritting a part of the code to have a nicer code overall. label Sep 16, 2024
Co-authored-by: GitHub GTNH Actions <>
@boubou19 boubou19 added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Sep 16, 2024
OrePrefixes.toolHeadHammer,
OrePrefixes.toolHeadFile,
OrePrefixes.toolHeadSaw,
OrePrefixes.toolHeadDrill,
OrePrefixes.toolHeadChainsaw,
OrePrefixes.toolHeadWrench,
OrePrefixes.toolHeadUniversalSpade,
OrePrefixes.toolHeadSense,
OrePrefixes.toolHeadPlow,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ___placeholder___ instead of removing the prefixes, otherwise you shift all the meta ids

@boubou19
Copy link
Member

Sense should be added back but as a single item, its AOE cleaning ability is nice. (or we add AOE to mattocks)

@LazyFleshWasTaken
Copy link

Can we at least keep gt pick in? For some people that don't want to use tinker's for some time at the beginning they can do flint pick -> small iron/banded iron/magnetite/whatever ore -> ingots -> hammer -> gt pick -> full ores.

Or, if the gt tools are removed, can the vanilla ones be re-enabled with a matching recipe to not remove the alternative progression?

@boubou19
Copy link
Member

boubou19 commented Sep 16, 2024

Can we at least keep gt pick in? For some people that don't want to use tinker's for some time at the beginning they can do flint pick -> small iron/banded iron/magnetite/whatever ore -> ingots -> hammer -> gt pick -> full ores.

Or, if the gt tools are removed, can the vanilla ones be re-enabled with a matching recipe to not remove the alternative progression?

We want to improve early game by removing bloat. GT pickaxes are just some pickaxes. We want to properly integrate and balance tinker construct stuff in the progression. Part of this effort is to remove the absurd amount of materials in tinker so we can properly balance the tools, part of this effort is to remove GT tools, so the progression is simplier. Tinker tools are objectively more interesting than GT pickaxes, and we have a huge interest to remove them, as it removes the tools, but also the pickaxe heads, and the recipes associated to them, resulting in a faster booting time, and less code to migrate for the future material rework.

The alternative progression path is an oversight, so aside maybe special behavior tools such as amethyst which has silk touch, they won't be added back.

@LazyFleshWasTaken
Copy link

Can we at least keep gt pick in? For some people that don't want to use tinker's for some time at the beginning they can do flint pick -> small iron/banded iron/magnetite/whatever ore -> ingots -> hammer -> gt pick -> full ores.
Or, if the gt tools are removed, can the vanilla ones be re-enabled with a matching recipe to not remove the alternative progression?

We want to improve early game by removing bloat. GT pickaxes are just some pickaxes. We want to properly integrate and balance tinker construct stuff in the progression. Part of this effort is to remove the absurd amount of materials in tinker so we can properly balance the tools, part of this effort is to remove GT tools, so the progression is simplier. Tinker tools are objectively more interesting than GT pickaxes, and we have a huge interest to remove them, as it removes the tools, but also the pickaxe heads, and the recipes associated to them, resulting in a faster booting time, and less code to migrate for the future material rework.

The alternative progression path is an oversight, so aside maybe special behavior tools such as amethyst which has pickaxe, they won't be added back.

I see. Nevermind then.
Also, it'd still technically be possible, you'd just have to use iron hammer instead of iron pickaxe, but it would also return crushed ores intead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. refactor For PRs rewritting a part of the code to have a nicer code overall.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants