Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in slabs and planks recipes for EtFuturumRequiem #933

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

Wmaxlees
Copy link

Context: GTNewHorizons/GT-New-Horizons-Modpack#16436

This introduces recipes for planks and slabs that matches existing GTNH recipes.

@Wmaxlees
Copy link
Author

Related PRs:

Et Futurum Requiem Config: GTNewHorizons/GT-New-Horizons-Modpack#16995
Add Et Futurum Requiem to modpack: GTNewHorizons/DreamAssemblerXXL#167

@Dream-Master Dream-Master requested a review from a team August 17, 2024 20:20
@Dream-Master
Copy link
Member

@Wmaxlees much more recipes need to be added

image
image
and all other bed variants
image
all chest upgrades
image
all Button recipes
Not sure if Netherite is enabled but the recipes need to have some gt styled recipes
image
image
Compressor recipe please
image
Trapp doors need a change
we have saw recipe for that
image

@Dream-Master
Copy link
Member

Idk this devices but the recipe looks very vanilla
Smithing Table, Loom, Composter, Stone Cutter, Fletching Table, Cartography Table,
need a gt recipe as well

@Dream-Master
Copy link
Member

If netherite is added we need some gt material to add plates and other stuff to enable weapons and armor

@Dream-Master
Copy link
Member

Does this mob spawn ?
image
if yes recipe need a rework as well and a gt material to add plates and other stuff

@Dream-Master
Copy link
Member

@Wmaxlees

@EnderProyects
Copy link
Contributor

@Dream-Master This pr only aims to planks and slabs for the other things there are other people adding them

@Dream-Master
Copy link
Member

@EnderProyects i just said this pr is not done for a full integration of this mod. And we are freezing everything soon so if this have to be added for 2.7.0 the recipe part need to be done

@chochem
Copy link
Member

chochem commented Sep 3, 2024

adding a mod that does so much stuff right before stable doesnt sound like a good idea anyway. just add it to nightly after stable and we can slowly work on all the recipes.

@Dream-Master
Copy link
Member

i have not doubts freeze it and add it after 2.7.0 I thought it was done

@Dream-Master Dream-Master added the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants