Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildscript and general log cleanup #9

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

bombcar
Copy link
Member

@bombcar bombcar commented Feb 7, 2022

Migrate to new buildscript

Replace all printf uses with the logger

Remove commented out code

Remove unneeded imports

This should be tested on a setup with working stargates!

It builds and runs both on server and client, but I don't have an existing array to test against.

@bombcar bombcar requested review from boubou19 and a team February 7, 2022 19:21
Copy link

@mitchej123 mitchej123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tl;dr

@mitchej123 mitchej123 merged commit 275e461 into master Feb 8, 2022
@mitchej123 mitchej123 deleted the updatebuild branch February 8, 2022 04:31
@bombcar
Copy link
Member Author

bombcar commented Feb 8, 2022

@boubou19 does Zeta have stargate networks? This should be a drop in replacement for any version of SGCraft but I’d like to verify before it goes on Delta.

@boubou19
Copy link
Member

boubou19 commented Feb 8, 2022

because it's the test server, it doesn't have a stargate network (it could have one, but after setting it 3 times already, super lazy to make a 4th)

@bombcar
Copy link
Member Author

bombcar commented Feb 8, 2022

Ok so nothing should have changed at all as it was all logging and buildscript - but let’s assume it is broken - what would happen? Is it recoverable?

@boubou19
Copy link
Member

boubou19 commented Feb 8, 2022

worse thing that could happen is that the gates lose their adress so the game give new ones, messing every OC automation. But given not many players have a stargate, and not all of them know how to do proper oc interfacing, i'd say it's not that bad (except me redoing all the gates again but 🤷‍♂️ )

But if you really did what you listed then it will work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants