Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Enum Duplication Issue #118

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

KAMKEEL
Copy link
Contributor

@KAMKEEL KAMKEEL commented Feb 7, 2024

Adds Enum Map to keep track of all Enum Names associated with their Enum Classes

  • $1, $2, $3, $4.... and so on will be appended to the Enum Name until the Duplication clause is satisfied.

The issue in detail is explained here: #115
The enum names are case-insensitive when they are registered so all enums capitalized before comparison

…um Classes

- $1, $2, $3, $4.... and so on will be appended to the Enum Name until the Duplication clause is satisfied.
@makamys
Copy link
Contributor

makamys commented Feb 7, 2024

To elaborate on the case sensitivity issue, there's a mod called SkyForge (PlanetMinecraft | DDL) that registers the tool material name Glass. Before the code was made case insensitive, this still conflicted with Kam's Plugin Mod v5.2 which registers the name GLASS. (The materials are used by the Glass Sword and the Glass Dagger respectively.)

@eigenraven eigenraven merged commit 7fff831 into GTNewHorizons:master Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants