Removed support for .NET Framework-based ASP .NET Core applications #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-architected code base to use more relevant class names and directory structure; Now supports .NET 6, 7, and 8; Updated readme and changelog
jamie-taylor-rjj
changed the title
|
Fixes / closes #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this PR
In order to support .NET Framework-based ASP .NET Core applications, OwaspHeaders.Core had to take a dependency on
Microsoft.AspNetCore.Http.Abstractions, however as of this announcement (aka ASP .NET Core 3.0), .NET Framework is no longer supported by ASP .NET Core. As such this project now no longer supports .NET Framework.This is achieved by replacing the requirement on the NuGet package
Microsoft.AspNetCore.Http.Abstractionswith a Framework Reference onMicrosoft.AspNetCore.App.This PR fixes #88