Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against and fix for pdm>=2.19 #43

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

noirbizarre
Copy link
Contributor

@noirbizarre noirbizarre commented Sep 24, 2024

Hello 👋🏼

This PR:

  • adds pdm~=2.19 to the tox test suite
  • adds some basic integration tests for pdm which allowed to reproduce the 2.19 breakage and should now fail in the scheduled nightly when some breaking changes are incoming
  • fixes support for pdm>=2.19 by simply removing the unused keyword arguments from the post_install handler (which also makes it more resilient to future changes)

Note

Attestation has been disabled on pull requests and forks as this is not supported and recommanded not to.
See:

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (6073623) to head (2d21138).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   95.80%   96.32%   +0.52%     
==========================================
  Files           9        9              
  Lines         572      572              
  Branches      105      105              
==========================================
+ Hits          548      551       +3     
+ Misses         21       18       -3     
  Partials        3        3              
Flag Coverage Δ
unittests 96.15% <100.00%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GabDug
Copy link
Owner

GabDug commented Sep 26, 2024

As always, thanks a lot!

@GabDug GabDug merged commit ce5cda4 into GabDug:main Sep 26, 2024
12 checks passed
@noirbizarre noirbizarre deleted the fix/pdm-2.19 branch September 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants