Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphEditor : Lingering error badges #3820

Closed
themissingcow opened this issue Jul 8, 2020 · 1 comment
Closed

GraphEditor : Lingering error badges #3820

themissingcow opened this issue Jul 8, 2020 · 1 comment

Comments

@themissingcow
Copy link
Contributor

themissingcow commented Jul 8, 2020 •
edited
Loading

Description

GraphEditor still displays errors after the error scenario has been resolved.

image
In the above, the image sequence is valid for frames 1-4, the error was shown when the timeline was moved to frame 10, then persists even though the timeline has been moved back to frame 3.

Steps to reproduce

  1. Create an ImageReader, and load an image sequence.
  2. Move the current frame to something outside of the sequence range
  3. The error badge appears on the ImageReader node
  4. Move the current frame back to a valid time for which an image exists in the sequence.
  5. The viewer shows the image, but the error badge remains.

There seems to be no way to clear the error (it will have propagated to any other downstream nodes too).
@johnhaddon
Copy link
Member

This is a tricky one. We use plugDirtiedSignal() to clear the error indicator, and nothing in the steps above will trigger that. We could clear all error indicators on global context changes, and that would cover this specific case and a bunch of others, but still not be a general solution. We'd still have the "viewed through a node which didn't provide a necessary context variable, then viewed through a node which did" problem.

johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Sep 24, 2024
@johnhaddon
StandardNodeGadget : Fix lingering error badges
34ef1b7 
Errors are caused by evaluating nodes with bad input, either in the form of plug values or of context variables. We have always cleared error badges when plugs are dirtied, which takes care of the situation where the user has fixed the input in the form of plug values. But until now we have stuck our head in the sand completely when it comes to errors due to bad contexts.

But now we have the ContextTracker, we can associate errors with tracked contexts, and when the tracked context changes, clear any errors from previous contexts.

Fixes GafferHQ#3820.
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Sep 24, 2024
@johnhaddon
StandardNodeGadget : Fix lingering error badges
a8fd2ca 
Errors are caused by evaluating nodes with bad input, either in the form of plug values or of context variables. We have always cleared error badges when plugs are dirtied, which takes care of the situation where the user has fixed the input in the form of plug values. But until now we have stuck our head in the sand completely when it comes to errors due to bad contexts.

But now we have the ContextTracker, we can associate errors with tracked contexts, and when the tracked context changes, clear any errors from previous contexts.

Fixes GafferHQ#3820.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@themissingcow @johnhaddon