Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows build chain to MSVC 2022 #5490

Closed
ericmehl opened this issue Oct 9, 2023 · 6 comments
Closed

Update Windows build chain to MSVC 2022 #5490

ericmehl opened this issue Oct 9, 2023 · 6 comments

Comments

@ericmehl
Copy link
Collaborator

ericmehl commented Oct 9, 2023

This will keep us up to date with the VFX reference platform, and it should fix a bug MSVC introduces causing some disk partition types to not be usable : https://groups.google.com/g/gaffer-dev/c/zuAhqDFIl50

It will also hopefully allow useful ASan builds on Windows. Currently something in TBB causes ASan to error at startup, but recent MSVC 2022 builds have added the ability to continue on errors and collect a list of them after running.

@ericmehl ericmehl mentioned this issue Oct 9, 2023
4 tasks
@johnhaddon
Copy link
Member

Do you think it'd be reasonable to get this in for 1.4, @ericmehl?

@ericmehl
Copy link
Collaborator Author

ericmehl commented Nov 2, 2023

Yeah, I think it should be possible. Hard to know with MSVC, but the transition to 2019 wasn't too bad.

@boberfly
Copy link
Collaborator

I was successful in building Gaffer with VS2022 MSVC 14.3, it wasn't many patches but I can upstream them - it was mostly making MSVC_VERSION configurable for SCons and a few warning suppressors.

@johnhaddon
Copy link
Member

Maybe we can aim to get this done for 1.5 @ericmehl?

@ericmehl
Copy link
Collaborator Author

Yeah, we're overdue for updating to 2022 so prioritizing it for 1.5 would be great. @boberfly, if you want to put up a PR to GafferHQ / Dependencies, that would be a great help. I think it should target a new branch called 8_maintenance_msvc2022, based on the current names of the branches?

@johnhaddon
Copy link
Member

Closing as done in #6044.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants