Visual Studio 2022 build #6044
Merged
Visual Studio 2022 build #6044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates to a Visual Studio 2022 series compiler, which has a runtime library of 14.3, which is what SCons uses to choose the toolset.
This is a result of a fix in the dependencies, but noted here for better visibility to users. Fixes GafferHQ#5599
This was deprecated in c++17 and removed in c++20, in favor of `std::invoke_result_t`, which we use here.
This was deprecated in c++17 and removed in c++20 because it gives potentially incorrect results in a multithreaded environment. All of our uses are noted as not being able to be called by multiple threads, so the comparison `use_count() == 1` is valid.
johnhaddon
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Windows build to use Visual Studio 2022 / MSVC 17.8 / Runtime 14.3. In doing so, it uses the Gaffer dependencies 9.0.0a2 build, which is also built on MSVC 17.8.
Checklist