Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle Local Dispatcher Catalogue Issue - RHEL 9.4 #5905

Closed
A6i8 opened this issue Jun 17, 2024 · 0 comments
Closed

Cycle Local Dispatcher Catalogue Issue - RHEL 9.4 #5905

A6i8 opened this issue Jun 17, 2024 · 0 comments

Comments

@A6i8
Copy link

A6i8 commented Jun 17, 2024

Version: Gaffer 1.4.3.0-linux-gcc9
Third-party tools: None
Third-party modules: None

Linux version: 5.14.0-427.16.1.el9_4.x86_64
ldd (GNU libc) : 2.34

Description

After local rendering and saving image, image is not updating on Catalogue but with InteractiveRender working fine.

Steps to reproduce

  1. Create a file with Sphere, background_light Camera, StandardOptions, CyclesOptions and Outputs
  2. Try to render with default setting
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Jun 17, 2024
This still doesn't support a mix of `ieDisplay` and file outputs, but that isn't a particularly common configuration at least. The output handling could benefit from a much bigger overhaul but here I've limited myself to the most minimal changes necessary to fix the problem. Future improvements could include :

- Moving more logic in CyclesOutput, instead of having much of it in `updateOutputs()`.
- A single `ccl::OutputDriver` subclass that supports writing to file via OIIO as well as rendering to `ieDisplay`.

That can wait though.

I'm pretty sure this fixes GafferHQ#5905, but can't say with 100% certainty because the issue description is so vague.
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Jun 17, 2024
This still doesn't support a mix of `ieDisplay` and file outputs, but that isn't a particularly common configuration at least. The output handling could benefit from a much bigger overhaul but here I've limited myself to the most minimal changes necessary to fix the problem. Future improvements could include :

- Moving more logic in CyclesOutput, instead of having much of it in `updateOutputs()`.
- A single `ccl::OutputDriver` subclass that supports writing to file via OIIO as well as rendering to `ieDisplay`.

That can wait though.

With this fix we can now use Batch renders where we logically want to in the unit tests instead of using Interactive renders just to use the display driver we want. I'm also pretty sure this fixes GafferHQ#5905, but can't say with 100% certainty because the issue description is so vague.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant