SetEditor : Display and filter by selected set members #5580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Thanks for the quick turnaround on this Murray - it definitely seems a very useful feature. Of my inline comments, I think the only one we need to resolve (one way or another) before merging is the one about & vs in, but it might be good to consider doing the others reasonably soon.
murraystevenson
force-pushed
the
setEditorSelectionFilter
branch
from
6f420e0 to
8a4099a
Compare
|
Thanks for the input! I've rebased to fix the |
This is in order to define header and cell tooltips, maybe in the future we'll be able to do this directly for header tooltips via StandardPathColumn.
johnhaddon
force-pushed
the
setEditorSelectionFilter
branch
from
8a4099a to
6791bee
Compare
|
Thanks Murray! I've squashed in the fixups and am merging for release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new "Selection" column and "Hide Empty Selection" checkbox to the Set Editor. These display the number of currently selected scene locations that are a member of each set, and allow the list of sets to be filtered to only display those with currently selected members. These aim to aid in introspection of scenes containing large numbers of sets, where a user may only be currently interested in the sets a selection of scene locations are a member of.
setEditorEmptySelection.mp4