Support Arnold 7.3 #5757
Merged
Support Arnold 7.3 #5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
force-pushed
the
arnold73
branch
3 times, most recently
from
b47ab1d to
1c23baf
Compare
|
LGTM |
I can't see any reason we were trying to construct FloatData from the return value of `AiNodeSetStr()` - it just seems like a typo. That function now returns `None` so the `FloatData` construction fails.
This is just a case of accounting for a new `color_manager_ocio.ignore_environment_variable` attribute.
The test images were so noisy that differences in noise patterns in Arnold 7.3 caused the tests to fail. Upping samples means that we have a much cleaner image, and boosting exposure means that the allowed delta is now much smaller compared to the expected value.
These seem to have appeared somewhere in the `7.2.x` series.
This is awkward, because the AI_NODE_IMAGER type is only introduced in 7.3.1.0, and _not_ 7.3.0.0 where you might expect a source/ABI break. So while this code will now compile/run with either 7.3.0.0 or 7.3.1.0, we can't compile with one version and use the other.
This is now provided by the Arnold core in Arnold 7.3, rather than being duplicated in each of the official DCC plugins (and not existing at all in poor old Gaffer).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the minor adjustments necessary for supporting Arnold 7.3.
There's a small bit of awkwardness here in that the AI_NODE_DRIVER -> AI_NODE_IMAGER transition happened in 7.3.1.0 and not in 7.3.0.0, despite them both being released on the same day. So code compiled with 7.3.1.0 will fail to recognise imagers in 7.3.0.0 (and vice versa). Rather than contort things further to deal with this or provide builds for minor versions (which are not generally needed, i checked), I've just documented that we don't support 7.3.0.0. HtoA and KtoA are apparently skipping 7.3.0.0 as well - the only reason it exists is because Arnold is the built-in renderer for Max/Maya, and a version needed to be locked down earlier for QA reasons (as far as I understand it anyway).