Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows GafferArnold tests #5860

Open
wants to merge 14 commits into
base: 1.4_maintenance
Choose a base branch
from
Open

Commits on May 17, 2024

  1. Configuration menu
    Copy the full SHA
    43437d6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    86b2ebf View commit details
    Browse the repository at this point in the history
  3. IECoreArnoldTest : Close beauty.exr

    Windows won't be able to delete the temporary file in `tearDown()` if
    it is still open.
    ericmehl committed May 17, 2024
    Configuration menu
    Copy the full SHA
    148ff05 View commit details
    Browse the repository at this point in the history
  4. OutputDriverTest : Skip tests on Windows

    Calling `kick` from Gaffer currently doesn't work for at least two
    reasons:
    
    1. We create an Arnold plugin called `Gaffer.dll`. When calling `kick`,
    it will attempt to load this plugin. `kick` seems to think it should
    use the `Gaffer.dll` we build for core Gaffer - renaming the plugin
    fixes the loading problem.
    2. Even with that fix, there's an error `IECoreGL::init::DllMain :
    Failed to register window class`. I'm not sure what the cause of this
    error is yet.
    ericmehl committed May 17, 2024
    Configuration menu
    Copy the full SHA
    ab1ad7f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    81bb81a View commit details
    Browse the repository at this point in the history
  6. RendererTest : Skip log related tests on Windows

    - Windows doesn't allow read-only directories, so we split that part out
    of `testLogDirectoryCreation` into a separate test we can skip.
    - Something is holding the Arnold log open even after destroying the
    renderer. This prevents Windows from cleaning up without errors.
    ericmehl committed May 17, 2024
    Configuration menu
    Copy the full SHA
    0f0d534 View commit details
    Browse the repository at this point in the history
  7. UniverseBlockTest : Adapt for Windows

    - Use "gaffer.cmd". We don't use `str( Gaffer.executablePath() )` to
    avoid the dependency on the `Gaffer` module.
    - Arnold returns `atStringStruct` instead of `atStringReturn`.
    - Don't attempt to run `kick` which isn't working on Windows currently.
    ericmehl committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c3a398b View commit details
    Browse the repository at this point in the history
  8. GafferArnoldTest : Fix output paths

    When setting outputs directly with `addOutput`, we need to do the
    conversion to `/`-based paths because there is no string plug to do
    the conversion for us.
    ericmehl committed May 17, 2024
    Configuration menu
    Copy the full SHA
    993cfe6 View commit details
    Browse the repository at this point in the history
  9. SceneGadgetTest : Idle tries in waitForRender()

    Without this, on Windows `GafferArnoldUITest` errors with a long string
    of `ERROR : Qt : QEventDispatcherWin32::wakeUp: Failed to post a message (Not enough quota is available to process this command.)`
    ericmehl committed May 17, 2024
    Configuration menu
    Copy the full SHA
    979106b View commit details
    Browse the repository at this point in the history
  10. ArnoldShaderUITest : Use script file

    On Windows, the script to build the scene in `testUserDefaultMetadata()`
    was failing to execute correctly, resulting in no scene being written.
    I don't know exactly the cause, but writing out the script to a
    temporary file works around whatever differences there are in passing
    a multi-line command to Python.
    ericmehl committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c4afa7a View commit details
    Browse the repository at this point in the history
  11. ArnoldSceneGadgetTest : Skip objectAt tests

    `GafferArnold` on Windows does not seem to reliably fill the id or depth
    buffers used by `SceneGadget::objectAt()` ( via `OutputBuffer::idAt` ).
    
    In order to get the vast majority of GafferArnold tests activated, we
    skip these for now.
    ericmehl committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c9f86ae View commit details
    Browse the repository at this point in the history
  12. InteractiveArnoldRenderTest : Skip test on Windows

    Automated testing of automatic light groups fails, whereas the same
    tests done manually give the expected results.
    
    In order to get the vast majority of GafferArnold tests activated, we
    skip this test for now.
    ericmehl committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6349692 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Configuration menu
    Copy the full SHA
    a48b8f6 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Windows run in powershell

    ericmehl committed May 21, 2024
    Configuration menu
    Copy the full SHA
    876d23f View commit details
    Browse the repository at this point in the history