ShadingEngine : Support 64 bit ints in RendererServices::get_userdata()
#6117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes.md
Outdated
| @@ -5,6 +5,7 @@ Fixes | |||
| ----- | |||
|
|
|||
| - CyclesShader : Fixed broken presets menus. | |||
| - OSLObject : Fixed `getattribute()` to support 64 bit integer data, such as an `instanceId` primitive variable loaded from USD. | |||
There was a problem hiding this comment.
Should we be mentioning here that it is "supported" via truncation? This kind of makes it sound like you could read all 64 bits?
There was a problem hiding this comment.
Good point - I've added a note to that effect in the latest push.
…a()` This requires ImageEngine/cortex#1439 to work.
johnhaddon
force-pushed
the
shadingEngineInt64
branch
from
e5e40ab
to
d63d0ea
Compare
|
LGTM, once the Cortex change is available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires ImageEngine/cortex#1439 to work.