Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused modules #1301

Closed
wants to merge 2 commits into from
Closed

Remove unused modules #1301

wants to merge 2 commits into from

Conversation

AlexKurek
Copy link

No description provided.

@rmjarvis
Copy link
Member

This breaks the unit tests. Did you try running the tests yourself before submitting the PR?

@AlexKurek
Copy link
Author

This breaks the unit tests. Did you try running the tests yourself before submitting the PR?

Not really, I didnt even know it is possible to run the test by myself (offline?).
It seems I remove some actually needed module(s). Interesting that only MacOS test failed.

@rmjarvis
Copy link
Member

Once one of them fails, the rest are canceled. That's standard GHA behavior. The MacOS run just happened to be the first one to get to the error.

And yes, you can run the tests yourself. Install the code on your branch. Then run pytest in the tests directory.

@rmjarvis rmjarvis added the cleanup Non-functional changes to make the code better label Jul 24, 2024
@AlexKurek
Copy link
Author

I am not making much progress fixing this. Is it okay if I undo my changes and do it again, this time testing things locally?

@rmjarvis
Copy link
Member

rmjarvis commented Jul 30, 2024

Is it okay if I undo my changes and do it again, this time testing things locally?

Sure.

@AlexKurek AlexKurek closed this by deleting the head repository Aug 2, 2024
@rmjarvis rmjarvis added this to the No action milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional changes to make the code better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants