-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:browse seems wrong when given parameters #689
Comments
Just to be clear: You're not proposing that |
Oh yes, |
This implements the feature request in #689
This implements the feature request in #689
This fixes a bug where the scoping on the command line was incorrect for nested modules. It also changes the semantics of `:browse` (whose implementation is now in a separate module), to be more reasonable. See #689
I've just redone how browse works in the "Nested Modules" PR. I settled on the following semantics:
This seems simple an consistent, and is more or less what I'd want most of the time, I think. |
PR #1682 introduces |
The current behavior of
:browse M
is to see information about names defined inM
from the point of view of the currently focused module. This means that you only ever get to see information about public names inM
and only if you imported them.This seems confusing. I propose that we change
:browse
to work as follows::browse
with no parameters shows information about what's current in scope at the REPL. This includes the currently focused module, plus any dynamic bindings (e.g.,let
bound, orit
):browse M
shows all information aboutM
, no matter what's currently in scope at the REPL.Thoughts?
The text was updated successfully, but these errors were encountered: