Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI masks build failure #953

Closed
robdockins opened this issue Nov 10, 2020 · 0 comments · Fixed by #968
Closed

CI masks build failure #953

robdockins opened this issue Nov 10, 2020 · 0 comments · Fixed by #968
Assignees
@lisanna-dettwyler
Labels
build system Related to Cryptol's build system

Comments

@robdockins
Copy link
Contributor

In a recent PR build, the CI task crashed in the middle of a build for some reason.

https://github.com/GaloisInc/cryptol/runs/1381112825?check_suite_focus=true#step:8:93

This is annoying, but more critically, the CI job masked this failure and continued on to the testing phase, and only failed because a test designed to exercise the new behavior failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lisanna-dettwyler lisanna-dettwyler

Labels
build system Related to Cryptol's build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cry: propagate command failure GaloisInc/cryptol
3 participants
@robdockins @hazelweakly @lisanna-dettwyler