Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the runtime-settable options to use a consistent style #1073

Merged
merged 3 commits into from
Feb 16, 2021

Conversation

robdockins
Copy link
Contributor

Options are now all named in camelCase style. However, multiword
options may still be set using the old hypenated names as aliases,
so interaction scripts and the test suite do not have to be
changed. In addition, option lookup is altered to be case insensitive.

Thus, the canonical option name for the output SMT file when
an offline prover is selected is smtFile, which is what will
show up when running :set with no arguments, and what will be
suggested for tab-completion. However, the option may be set
using the strings smtfile SMTFile, smt-file, SMT-file, etc.

Fixes #656

Options are now all named in camelCase style.  However, multiword
options may still be set using the old hypenated names as aliases,
so interaction scripts and the test suite do not have to be
changed. In addition, option lookup is altered to be case insensitive.

Thus, the canonical option name for the output SMT file when
an offline prover is selected is `smtFile`, which is what will
show up when running `:set` with no arguments, and what will be
suggested for tab-completion.  However, the option may be set
using the strings `smtfile` `SMTFile`, `smt-file`, `SMT-file`, etc.

Fixes #656
@robdockins robdockins requested a review from yav February 11, 2021 22:54
Copy link
Member

@yav yav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@robdockins robdockins merged commit 538b6c4 into master Feb 16, 2021
@RyanGlScott RyanGlScott deleted the standardize-set branch March 22, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent style across :set option names
2 participants