Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make freshVar produce a VWord instead of a VSeq for type [0]. #1096

Merged
merged 3 commits into from
Mar 2, 2021
Merged

Make freshVar produce a VWord instead of a VSeq for type [0]. #1096

merged 3 commits into from
Mar 2, 2021

Conversation

brianhuffman
Copy link
Contributor

Fixes #1093. Fixes #1094.

@brianhuffman brianhuffman requested a review from robdockins March 2, 2021 20:18
@brianhuffman
Copy link
Contributor Author

I'll also add a regression test before merging this PR.

robdockins
robdockins suggested changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test should definitely exercise a What4 backend too. This is a tricky corner case, and as I recall the n > 0 test was there for a reason. We should make sure it works for all the use cases.

@brianhuffman brianhuffman requested a review from robdockins March 2, 2021 22:10
@brianhuffman brianhuffman merged commit 8f914a7 into master Mar 2, 2021
@brianhuffman brianhuffman deleted the symbolic-bv0 branch March 2, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdockins robdockins robdockins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@brianhuffman @robdockins