Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Move contents of __init__.py to new commands.py, connection.py files #1181

Merged
merged 3 commits into from
Apr 27, 2021

Conversation

m-yac
Copy link
Contributor

@m-yac m-yac commented Apr 23, 2021

This mirrors the organization of the SAW python bindings, and will enable us to export a new interface from __init__.py which depends on the old. The exports of __init__.py should stay the same, so no scripts should have to be updated.

@m-yac m-yac requested review from atomb and pnwamk April 23, 2021 19:41
Copy link
Contributor

@pnwamk pnwamk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add those two names to __all__ for consistency and then I think this is good if everything works unmodified (which it looks like it does).

Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, too. (I'm assuming that the large removal and addition chunks are just to move code, rather than change it, so I haven't looked at them carefully.)

@m-yac m-yac merged commit 7950584 into master Apr 27, 2021
@m-yac m-yac deleted the rpc/refactor-init-py branch April 27, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants