Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue 1191 #1192

Merged
merged 5 commits into from
May 6, 2021
Merged

Fix for issue 1191 #1192

merged 5 commits into from
May 6, 2021

Conversation

robdockins
Copy link
Contributor

Fixes #1191

robdockins added 4 commits May 5, 2021 15:52
@robdockins
Fix #1191
0707bdc 
The barrel shifter was being called with the wrong width; the
length of the sequence to be shifted was passed instead of the number
of bits in the index word.
@robdockins
Dispatch to shiftSeqByInteger and shiftSeqByWord
6497dae 
in the `BitmapVal` cases of `shiftWordByInteger` and
`shiftWordByWord`.
@robdockins
A bit more documentation
a081657
@robdockins
Add test case for issue 1191
a05b4ed
@robdockins robdockins requested a review from brianhuffman May 6, 2021 00:45
brianhuffman
brianhuffman approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@brianhuffman brianhuffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@robdockins robdockins merged commit ac4500a into master May 6, 2021
@RyanGlScott RyanGlScott deleted the issue1191 branch March 22, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianhuffman brianhuffman brianhuffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in some shift/rotates
2 participants
@robdockins @brianhuffman