Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Fix bug where an empty list is sent back from the server as Unit #1194

Merged
merged 2 commits into from
May 7, 2021

Conversation

m-yac
Copy link
Contributor

@m-yac m-yac commented May 6, 2021

For example, when using the cryptol Python bindings c.eval('[]') returns () when it should return [].

This change fixes the commented-out code in this example.

@m-yac m-yac requested review from atomb and pnwamk May 6, 2021 22:43
@pnwamk pnwamk merged commit 2d9250a into master May 7, 2021
@pnwamk pnwamk deleted the rpc/fix-readBack-empty-list branch May 7, 2021 23:27
yav pushed a commit that referenced this pull request May 26, 2021
…#1194)

* make readBack of an empty list actually return an empty list

* update test_SHA256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants