Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for all solver backends for cryptol server/client #1224

Merged
merged 6 commits into from
Jul 2, 2021

Conversation

pnwamk
Copy link
Contributor

@pnwamk pnwamk commented Jun 29, 2021

Makes available both SBV and What4 based solver backends in the RPC server and Python client.

Addresses GaloisInc/argo#173

Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the offline SMT-Lib contents should probably be Text instead of String, but otherwise this is great. Thanks for updating the docs along with the code. :)

cryptol-remote-api/src/CryptolServer/Sat.hs Outdated Show resolved Hide resolved
cryptol-remote-api/src/CryptolServer/Sat.hs Outdated Show resolved Hide resolved
cryptol-remote-api/src/CryptolServer/Sat.hs Outdated Show resolved Hide resolved
cryptol-remote-api/src/CryptolServer/Sat.hs Outdated Show resolved Hide resolved
@pnwamk
Copy link
Contributor Author

pnwamk commented Jul 1, 2021

Comments addressed and passing all tests (the two failures are unrelated). Planning on merging soon.

@pnwamk pnwamk merged commit 571f0dd into master Jul 2, 2021
@pnwamk pnwamk deleted the rpc/w4-solvers branch July 2, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants