Add arrayCopy, arraySet, arrayRangeEqual array primitives. #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…angeLookup and arrayRangeUpdate.
robdockins
reviewed
Aug 20, 2021
lib/Array.cry
Outdated
| arrayRangeUpdate : {a, b, n} (Integral a, fin n, n >= 1, Literal (n - 1) a) => (Array a b) -> a -> [n]b -> (Array a b) | ||
| arrayRangeUpdate arr idx vals = arrs ! 0 | ||
| where | ||
| arrs = [arr] # [ arrayUpdate acc (idx + i) val | acc <- arrs | i <- [0 .. (n - 1)] | val <- vals ] |
There was a problem hiding this comment.
It's a small thing, but I think you could avoid the n >= 1 constraint if you used the i <- [ 0 ..< n ] enumeration form instead.
I think the n >= 1 constraint is also unnecessary for arrayRangeLookup.
robdockins
reviewed
Aug 25, 2021
lib/Array.cry
Outdated
| * Copy elements from the source array to the destination array. | ||
| * | ||
| * 'arrayCopy dest_arr dest_idx src_arr src_idx len' copies the | ||
| * elements from 'src_arr' at indices '[src_idx .. (src_idx + len)]' into |
There was a problem hiding this comment.
Sorry to nitpick some more, but I think essentially all these ranges are intended to be half-open and we should probably use the Cryptol-style notation for that, which would make this [src_idx ..< (src_idx + len)], and similar below.
robdockins
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add arrayRangeLookup and arrayRangeUpdate helpers.