[RPC] Clean up to_cryptol
interface in cryptoltypes.py
#1312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
cryptoltypes.py
has the functionsto_cryptol
,CryptolType.from_python
, andCryptolType.convert
, all of which do approximately the same thing. Only the first is used in any current code in this repo or in saw-script, so this PR removes the latter two.Currently,
__to_cryptol__
has aCryptolType
parameter that does nothing, andto_cryptol
has aCryptolType
parameter that only matters in the following two cases:Otherwise every Python value has a unique
CryptolType
, so the parameter is unused. TheseCryptolType
parameters are never actually used in any current code in this repo or in saw-script, and I prefer the expressions on the RHS of the equalities above anyway, so this PR also removes these parameters.NB: This could potentially break someone's code if they use one of the deleted functions or parameters.