Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update regression test for issue #835. #1417

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Update regression test for issue #835. #1417

merged 1 commit into from
Aug 26, 2022

Conversation

taimoorzaeem
Copy link
Contributor

Fixes issue #1329.

@RyanGlScott
Copy link
Contributor

Thanks! By the way, for future reference: you don't need to open a new PR for each new change you make. Feel free to rebase your changes onto the same branch. This helps keeps the discussion for a particular task contained within a single PR, which makes it easier to review.

@taimoorzaeem
Copy link
Contributor Author

This helps keeps the discussion for a particular task contained within a single PR, which

Yeah sure!

RyanGlScott
RyanGlScott approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happily, the CI passes this time. Let's land this!

@RyanGlScott RyanGlScott merged commit bc92cd0 into GaloisInc:master Aug 26, 2022
@RyanGlScott RyanGlScott mentioned this pull request Aug 26, 2022
Closed
@taimoorzaeem taimoorzaeem deleted the issue1329 branch August 26, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taimoorzaeem @RyanGlScott