Functors iface tysyn #1459
Closed
Functors iface tysyn #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we resolve an undfined name we record error, but we continue processing things, so that we can report multiple errors. As a result we need to generate some sort of fake "real" name for the undefined entity. Previously we used to generate a fake local name, but that confused parts of the code that expected certain things to always be defined at the top level. So now we generate a fake name in the Cryptol prelude instead.
Also, for the names of the imported instances now use the location in the file to make them unique, rather than a synthetic counter,
Still to do: modules and funcotrs
When we find an undefined name we record an error, but we also generate a fake name, so that we can continue processing and report other errors. It is important that we don't try to use this fake name. This commit corrects this behavior where we'd try to get information about an undefined intrface submodule. Fixes #1440
# Conflicts: # docs/RefMan/_build/doctrees/BasicSyntax.doctree # docs/RefMan/_build/doctrees/BasicTypes.doctree # docs/RefMan/_build/doctrees/Expressions.doctree # docs/RefMan/_build/doctrees/FFI.doctree # docs/RefMan/_build/doctrees/Modules.doctree # docs/RefMan/_build/doctrees/OverloadedOperations.doctree # docs/RefMan/_build/doctrees/RefMan.doctree # docs/RefMan/_build/doctrees/TypeDeclarations.doctree # docs/RefMan/_build/doctrees/environment.pickle # docs/RefMan/_build/html/.buildinfo # docs/RefMan/_build/html/BasicSyntax.html # docs/RefMan/_build/html/BasicTypes.html # docs/RefMan/_build/html/Expressions.html # docs/RefMan/_build/html/FFI.html # docs/RefMan/_build/html/Modules.html # docs/RefMan/_build/html/OverloadedOperations.html # docs/RefMan/_build/html/RefMan.html # docs/RefMan/_build/html/TypeDeclarations.html # docs/RefMan/_build/html/_static/doctools.js # docs/RefMan/_build/html/_static/fonts/Lato-Bold.ttf # docs/RefMan/_build/html/_static/fonts/Lato-Regular.ttf # docs/RefMan/_build/html/_static/js/modernizr.min.js # docs/RefMan/_build/html/_static/searchtools.js # docs/RefMan/_build/html/searchindex.js # src/Cryptol/ModuleSystem.hs # src/Cryptol/ModuleSystem/Base.hs # src/Cryptol/ModuleSystem/InstantiateModule.hs # src/Cryptol/Parser/AST.hs # src/Cryptol/Parser/ParserUtils.hs # src/Cryptol/REPL/Command.hs # src/Cryptol/Transform/AddModParams.hs # src/Cryptol/Transform/Specialize.hs # src/Cryptol/TypeCheck/Infer.hs # src/Cryptol/TypeCheck/InferTypes.hs # src/Cryptol/Utils/Ident.hs
At the moment this kind of representes "False" so we need to handle it. In the future, we probaly should: * add an explicit `TFalse` to distinguish between malformed and False * Eliminate obviously false guards when instantiating a funcotr
PR #1403 accidentally removed our build coverage for an older Ubuntu LTS configuration. This patch adds in back and ensures that we don't accidentally run the tests on this configuration.
# Conflicts: # src/Cryptol/TypeCheck/Sanity.hs
This is mostly for debugging.
Not at all tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.