Support building with GHC 9.4 #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains a varity of changes needed to make the libraries in the `cryptol` repo compile with GHC 9.4: * GHC 9.4 is pickier about requiring the use of the `FlexibleContexts` extension, that is now enabled in more places. * I bumped the upper version bounds of various dependencies to allow them to build with GHC 9.4. Fixes #1487.
GHC 9.4 adds `-Wtype-equality-requires-operators` to `-Wall`, which warns about certain uses of type equalities that are not forward-compatible with planned changes in GHC. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=b60e52482a666d25638d59cd7e86851ddf971dc1#-is-now-a-type-operator) of the GHC 9.4 Migration Guide. These warnings are easily fixed by enabling the `TypeOperators` extension.
kquick
approved these changes
Feb 27, 2023
Closed
RyanGlScott
added a commit
that referenced
this pull request
Mar 10, 2023
The downstream `saw-remote-api` library doesn't quite support `vector-0.13.*` yet, but #1499 accidentally restricted `cryptol-remote-api`'s build plan to only allow `vector-0.13.*`. This restores the ability to build `cryptol-remote-api` with `vector-0.12.*` for `saw-remote-api`'s sake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a varity of changes needed to make the libraries in the
cryptolrepo compile with GHC 9.4:
FlexibleContextsextension, that is now enabled in more places.Fixes #1487.