Strips whitespace to be more compatible with pandoc output #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
Feb 21, 2023
src/Cryptol/Parser/Unlit.hs
Outdated
| @@ -105,7 +105,7 @@ markdown = blanks [] | |||
|
|
|||
| isOpenFence l | |||
| | "```" `Text.isPrefixOf` l' = | |||
| Just $ case Text.drop 3 l' of | |||
| Just $ case Text.strip (Text.drop 3 l') of | |||
There was a problem hiding this comment.
Would it suffice to just use Text.dropWhile isSpace here instead of Text.strip? The latter strips off whitespace from the end of the line, but I don't think that is necessary here, given that the code is already checking is cryptol is a prefix. As a result, it shouldn't matter if there is trailing whitespace at the end. (Please correct me if I've overlooked something, of course.)
There was a problem hiding this comment.
Nope, that's right :) I'll make that tweak and push...
|
One more thing: would you be able to add a test case that exercises this new feature? (If not, I can push a test case myself when I have a chance.) |
|
Sure, let me take a look |
RyanGlScott
approved these changes
Feb 22, 2023
RyanGlScott
added a commit
that referenced
this pull request
Jun 22, 2023
RyanGlScott
added a commit
that referenced
this pull request
Jun 22, 2023
RyanGlScott
added a commit
that referenced
this pull request
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1501